Increase timeout for reboot to bootloader #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we had a timeout of 15 seconds for the user presence check when rebooting to bootloader. This can be too short in some situations, see for example Nitrokey/nitrokey-3-firmware#519. This patch increases the timeout to 30 seconds.
daringer
approved these changes
Aug 1, 2024
|
Is this the right timeout? I don't understand why that solves the issue of taking a long time to mount the device since the device is already mounted when the reboot call happens. |
|
Hmm, I might have misread the request. Sometimes the reboot is referred to as reset, and in my mind Qubes is directly linked to bootloader reboot problems. Let’s clarify in the other issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we had a timeout of 15 seconds for the user presence check when rebooting to bootloader. This can be too short in some situations, see for example Nitrokey/nitrokey-3-firmware#519.
This patch increases the timeout to 30 seconds.