Merged
Conversation
…s input fields where present in screen, since loops where nested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'Drag&Drop' events where binded to each 'upload form' as many times as input fields where present in screen, since loops where nested.
Binding the same event (using ANONYMOUS function) to a component, more than once, DOES really bind the event N times (as opposite of binding non anonymous functions). So, when dropping files onto form, 'drop' event was executed N times and the same file was attached N times to the same item.
The solution is unnest loops, loops must occur one after other.
This code could be easly improved, since inside each 'upload form' there is only one 'input filed' to bind events, there is no need of a second loop, but this is not the point of this fix.