Skip to content

fix(public): review-dispose the missing managed-service section as the snoozed buyer path - #88

Merged
nish3451 merged 8 commits into
mainfrom
fix/lane1-managed-service-section-review-guard
Aug 19, 2026
Merged

fix(public): review-dispose the missing managed-service section as the snoozed buyer path#88
nish3451 merged 8 commits into
mainfrom
fix/lane1-managed-service-section-review-guard

Conversation

@nish3451

@nish3451 nish3451 commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Problem

Grok live-review finding ([unreviewed-by-grok]): the live homepage is
missing the entire <section id="managed-service"> block while the merged
homepage on main carries it.

Reviewed 2026-08-11: intended, snooze honored — not a regression.

This change

Encodes the verdict in the guards so future reviews find it instead of
re-flagging the section:

  • scripts/check-public-live-deploy.mjs — assert id="managed-service" and
    the exact section opening marker are absent from the live homepage
    (previously only covered indirectly via the "Website Correction" phrase);
    document the disposition in the header.
  • scripts/prepare-public-deploy-bundle.mjs — forbid id="managed-service"
    in the bundle alongside the other snooze markers.
  • docs/measurement/public-conversion-signal.md — record the review
    disposition with live evidence and the lift condition (section returns
    only when Nish lifts the snooze; the fail-closed filter is then updated
    deliberately).

Validation

  • npm test → 623 checks, 0 failures, exit 0 (deploy-bundle guard now
    64 checks).
  • node scripts/check-public-live-deploy.mjs → the new managed-service
    checks pass against the live site ("homepage has no id="managed-service"",
    "the entire managed-service section block is absent"). The 6 pre-existing
    failures (JSON-LD, non-affiliation copy, real-404s, heading hierarchy)
    are the known stale June-20 deployment, unrelated to this change.
  • git diff --check clean.

Summary by CodeRabbit

  • Documentation

    • Clarified that the managed-service section is intentionally absent from the homepage and documented the conditions for restoring it.
    • Added details about the snoozed deployment status, fail-closed filtering, and live-site verification.
  • Chores

    • Strengthened deployment checks to confirm the managed-service section remains excluded from published bundles while other buyer-path content is validated.
    • Added safeguards to reject bundles that accidentally include the managed-service homepage section.

…oozed by design

Grok live-review finding ([unreviewed-by-grok]): the live homepage is missing
the entire <section id="managed-service"> block while the merged homepage on
main carries it. Verified 2026-08-11: intended, not a regression - the
managed-service buyer path (PRs #10/#11) is snoozed-by-Nish 2026-08-08, the
release lane strips the section from every publishable bundle, and the live
site (still the 2026-06-20 bundle 07acd07) predates PR #10.

Encode the verdict in the guards so future reviews find it:
- check-public-live-deploy.mjs: assert id="managed-service" and the exact
  section marker are absent from the live homepage (previously only covered
  indirectly via the 'Website Correction' phrase); document the disposition
- prepare-public-deploy-bundle.mjs: forbid id="managed-service" in the
  bundle alongside the other snooze markers
- docs/measurement/public-conversion-signal.md: record the review disposition
  with live evidence and the lift condition

verify: npm test (623 checks, 0 failures); node scripts/check-public-live-deploy.mjs
(new managed-service checks pass; the 6 stale-bundle failures predate this change);
git diff --check

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 7076ef68-8e4a-4447-9f11-1b6c2cafe68d

📥 Commits

Reviewing files that changed from the base of the PR and between 33f19da and 38b7afe.

📒 Files selected for processing (2)
  • scripts/check-public-live-deploy.mjs
  • scripts/prepare-public-deploy-bundle.mjs
🚧 Files skipped from review as they are similar to previous changes (2)
  • scripts/prepare-public-deploy-bundle.mjs
  • scripts/check-public-live-deploy.mjs

Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

The deployment bundle filter rejects the managed-service homepage section. Live deployment checks verify its absence. Measurement documentation records the intentional snoozed state and restoration conditions.

Changes

Managed-service public deployment safeguards

Layer / File(s) Summary
Bundle filtering
scripts/prepare-public-deploy-bundle.mjs
Public deployment bundles reject the id="managed-service" homepage marker.
Live verification and disposition record
scripts/check-public-live-deploy.mjs, docs/measurement/public-conversion-signal.md
Live checks verify that the complete managed-service section is absent. Documentation records the snoozed state and restoration condition.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 38b7a

This PR makes the intentionally snoozed managed-service section explicitly absent from publishable and live-site checks and documents when it may return. The reported validation passes, and no actionable merge-blocking risk remains after normal checks and review.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the managed-service section as an intentionally snoozed buyer path and matches the main documentation and enforcement changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/lane1-managed-service-section-review-guard

Comment @coderabbitai help to get the list of available commands.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 705a7cca9d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +115 to +116
the live homepage has no managed-service section while the merged homepage on
main carries one. Verdict: **intended, snooze honored — not a regression.**

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reconcile the checkout state with this disposition

This newly added statement says the merged homepage carries the managed-service section, but the same document still says under “State in this checkout” that both homepage CTAs are absent because PR #10 was not merged, and line 25 states that the checkout has no Website Correction CTA. Since public/index.html does contain those CTAs and only the deploy bundle removes them, readers following this measurement contract receive contradictory source-state guidance; update the earlier table and paragraph to distinguish checkout content from the filtered live bundle.

Useful? React with 👍 / 👎.

…vice-section-review-guard

# Conflicts:
#	scripts/check-public-live-deploy.mjs

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@nish3451
nish3451 enabled auto-merge (squash) August 18, 2026 22:02
@nish3451
nish3451 merged commit a7d9961 into main Aug 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant