fix(public): review-dispose the missing managed-service section as the snoozed buyer path - #88
Conversation
…oozed by design Grok live-review finding ([unreviewed-by-grok]): the live homepage is missing the entire <section id="managed-service"> block while the merged homepage on main carries it. Verified 2026-08-11: intended, not a regression - the managed-service buyer path (PRs #10/#11) is snoozed-by-Nish 2026-08-08, the release lane strips the section from every publishable bundle, and the live site (still the 2026-06-20 bundle 07acd07) predates PR #10. Encode the verdict in the guards so future reviews find it: - check-public-live-deploy.mjs: assert id="managed-service" and the exact section marker are absent from the live homepage (previously only covered indirectly via the 'Website Correction' phrase); document the disposition - prepare-public-deploy-bundle.mjs: forbid id="managed-service" in the bundle alongside the other snooze markers - docs/measurement/public-conversion-signal.md: record the review disposition with live evidence and the lift condition verify: npm test (623 checks, 0 failures); node scripts/check-public-live-deploy.mjs (new managed-service checks pass; the 6 stale-bundle failures predate this change); git diff --check
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughThe deployment bundle filter rejects the managed-service homepage section. Live deployment checks verify its absence. Measurement documentation records the intentional snoozed state and restoration conditions. ChangesManaged-service public deployment safeguards
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR makes the intentionally snoozed managed-service section explicitly absent from publishable and live-site checks and documents when it may return. The reported validation passes, and no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 705a7cca9d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| the live homepage has no managed-service section while the merged homepage on | ||
| main carries one. Verdict: **intended, snooze honored — not a regression.** |
There was a problem hiding this comment.
Reconcile the checkout state with this disposition
This newly added statement says the merged homepage carries the managed-service section, but the same document still says under “State in this checkout” that both homepage CTAs are absent because PR #10 was not merged, and line 25 states that the checkout has no Website Correction CTA. Since public/index.html does contain those CTAs and only the deploy bundle removes them, readers following this measurement contract receive contradictory source-state guidance; update the earlier table and paragraph to distinguish checkout content from the filtered live bundle.
Useful? React with 👍 / 👎.
…vice-section-review-guard # Conflicts: # scripts/check-public-live-deploy.mjs
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Problem
Grok live-review finding (
[unreviewed-by-grok]): the live homepage ismissing the entire
<section id="managed-service">block while the mergedhomepage on main carries it.
Reviewed 2026-08-11: intended, snooze honored — not a regression.
(2026-08-08: do not build, publish, or deploy it without his explicit yes).
(
prepare-public-deploy-bundle.mjs, fail-closed both directions), andcheck-public-live-deploy.mjsasserts the buyer path is not live.PR feat(public): route founders to reviewed Website Correction #10; the filter would strip the section even on a fresh deploy.
This change
Encodes the verdict in the guards so future reviews find it instead of
re-flagging the section:
scripts/check-public-live-deploy.mjs— assertid="managed-service"andthe exact section opening marker are absent from the live homepage
(previously only covered indirectly via the "Website Correction" phrase);
document the disposition in the header.
scripts/prepare-public-deploy-bundle.mjs— forbidid="managed-service"in the bundle alongside the other snooze markers.
docs/measurement/public-conversion-signal.md— record the reviewdisposition with live evidence and the lift condition (section returns
only when Nish lifts the snooze; the fail-closed filter is then updated
deliberately).
Validation
npm test→ 623 checks, 0 failures, exit 0 (deploy-bundle guard now64 checks).
node scripts/check-public-live-deploy.mjs→ the new managed-servicechecks pass against the live site ("homepage has no id="managed-service"",
"the entire managed-service section block is absent"). The 6 pre-existing
failures (JSON-LD, non-affiliation copy, real-404s, heading hierarchy)
are the known stale June-20 deployment, unrelated to this change.
git diff --checkclean.Summary by CodeRabbit
Documentation
Chores