Repository navigation
fix(ops): guard against duplicate same-fix pull requests #80
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| name: PR Duplicate Guard | ||
|
|
||
| # Stops duplicate same-fix pull requests from silently piling up (the fleet | ||
| # kept dispatching the same finding to multiple lanes: #36/#44/#55/#56, | ||
| # #39/#49, #40/#52, #38/#48/#51, ...). On every PR event this job compares | ||
| # the PR's diff against every other OPEN pull request. When another open PR | ||
| # covers the same fix (>= 80% shared changed-file coverage and >= 50% patch | ||
| # similarity on the shared files), the check fails loudly and the job posts | ||
| # one marker comment naming the duplicate(s) and the canonical PR. The check | ||
| # is deliberately not a required status, so legitimate work never blocks on | ||
| # it; it exists to make the duplication visible the moment it happens. | ||
| # | ||
| # Run locally before opening a PR: | ||
| # node scripts/check-pr-duplicates.mjs --pr 0 --no-fail --repo OWNER/REPO | ||
| # (use the real PR number once the PR exists). | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, synchronize, reopened, ready_for_review] | ||
| workflow_dispatch: | ||
| inputs: | ||
| pr-number: | ||
| description: "PR number to check (defaults to the PR that triggered the run)" | ||
| required: false | ||
| type: string | ||
|
Comment on lines
+22
to
+25
There was a problem hiding this comment.
A Useful? React with 👍 / 👎. |
||
|
|
||
| permissions: | ||
| contents: read | ||
| pull-requests: write | ||
|
|
||
| concurrency: | ||
| group: pr-duplicate-guard-${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| duplicate-guard: | ||
| runs-on: [self-hosted, linux, x64, vps-verify] | ||
| steps: | ||
| - uses: actions/checkout@v7 | ||
| - uses: actions/setup-node@v7 | ||
| with: | ||
|
Comment on lines
+40
to
+41
There was a problem hiding this comment.
Unlike the existing repo-check workflow, these steps reference mutable major-version tags. If either tag is retargeted or its upstream release is compromised, replacement code runs on the self-hosted runner; Useful? React with 👍 / 👎. |
||
| node-version: 20 | ||
| - name: Detect same-fix duplicate open PRs | ||
| run: node scripts/check-pr-duplicates.mjs --pr "$PR_NUMBER" --comment | ||
|
There was a problem hiding this comment.
When a same-repository PR modifies Useful? React with 👍 / 👎. There was a problem hiding this comment.
In this Useful? React with 👍 / 👎. |
||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| GITHUB_REPOSITORY: ${{ github.repository }} | ||
| PR_NUMBER: ${{ github.event.inputs.pr-number || github.event.pull_request.number }} | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the inspected
pr-duplicate-guard.ymlworkflow, closing or merging a matched PR triggers none of these event types, so the remaining PR is never reevaluated. If the recommended canonical PR is closed without merging, the survivor retains both a failed check and a marker comment instructing maintainers to close it in favor of a PR that is no longer open; cleaning up only during later synchronizations does not help when its head remains unchanged. Add handling that reevaluates affected open peers when a PR closes, or periodically reconcile outstanding reports.Useful? React with 👍 / 👎.