This repository was archived by the owner on Oct 12, 2026. It is now read-only.
Repository navigation
fix(ops): unblock sender trust DKIM half with live Cloudflare selector #60
Closed
Closed
Changes from 8 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
6edda53
fix(ops): unblock sender trust DKIM half with live Cloudflare selector
nish3451 82cc9a6
docs(ops): regenerate sender and parity artifacts for DKIM-ready state
nish3451 d11ed6d
Merge branch 'main' into fix/sender-trust-unblock-dkim
nish3451 e187cb7
Merge branch 'main' into fix/sender-trust-unblock-dkim
nish3451 9dc43d8
Merge branch 'main' into fix/sender-trust-unblock-dkim
nish3451 5061888
Merge remote-tracking branch 'origin/main' into tmp-merge-60
nish3451 4c93892
Merge remote-tracking branch 'origin/main' into tmp2-60
nish3451 30cefdc
Merge branch 'main' into fix/sender-trust-unblock-dkim
nish3451 b0f20ac
Merge branch 'main' into fix/sender-trust-unblock-dkim
nish3451 223b55d
Merge branch 'main' into fix/sender-trust-unblock-dkim
nish3451 336401e
Merge branch 'main' into fix/sender-trust-unblock-dkim
nish3451 3772606
Merge branch 'main' into fix/sender-trust-unblock-dkim
nish3451 f457187
Merge branch 'main' into fix/sender-trust-unblock-dkim
nish3451 339e07b
Merge branch 'main' into fix/sender-trust-unblock-dkim
nish3451 64782e4
Merge branch 'main' into fix/sender-trust-unblock-dkim
nish3451 ab81159
Merge branch 'main' into fix/sender-trust-unblock-dkim
nish3451 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -108,13 +108,15 @@ ${configureCommand} | |
| - Do not invent the DKIM selector. Use the exact selector from the mail provider. | ||
| - If DKIM discovery finds a selector, still confirm it in the mail provider before saving it. | ||
| - For Google Workspace, the default selector is often \`google\`, but verify it in the Google Admin DKIM screen before saving it here. | ||
| - If the domain runs Cloudflare Email Routing or Email Sending (SPF includes \`_spf.mx.cloudflare.net\`), the DKIM records Cloudflare provides use selector \`cf2024-1\` for routed mail or \`cf-bounce\` for sent mail; confirm the exact selector in the Cloudflare dashboard before saving it here. | ||
| - Cloudflare TXT records are the normal DNS record type for DKIM, SPF, and DMARC values. | ||
|
Comment on lines
+113
to
114
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Derive all DKIM guidance from one verified state. The generated Markdown and HTML show Also applies to: 244-245 🤖 Prompt for AI Agents |
||
| - Keep the manual daily cap low while there is no reply data. | ||
|
|
||
| ## Sources | ||
|
|
||
| - FTC CAN-SPAM business guide: https://www.ftc.gov/business-guidance/resources/can-spam-act-compliance-guide-business | ||
| - Google Workspace DKIM setup: https://support.google.com/a/answer/174124 | ||
| - Cloudflare Email Service authentication (SPF/DKIM/DMARC): https://developers.cloudflare.com/email-service/concepts/email-authentication/ | ||
| - Cloudflare DNS TXT records: https://developers.cloudflare.com/dns/manage-dns-records/reference/dns-record-types/ | ||
| `; | ||
|
|
||
|
|
@@ -239,10 +241,11 @@ const html = `<!doctype html> | |
| <li>Add the DKIM TXT record in Cloudflare if the provider gives one.</li> | ||
| <li>Run <code>npm run send:setup</code>.</li> | ||
| </ol> | ||
| <p class="sub">If the domain uses Cloudflare Email Routing or Email Sending (SPF includes <code>_spf.mx.cloudflare.net</code>), the DKIM records Cloudflare provides use selector <code>cf2024-1</code> for routed mail or <code>cf-bounce</code> for sent mail; confirm the exact selector in the Cloudflare dashboard before saving it here.</p> | ||
| </section> | ||
| <section> | ||
| <h2>Sources</h2> | ||
| <p><a href="https://www.ftc.gov/business-guidance/resources/can-spam-act-compliance-guide-business">FTC CAN-SPAM guide</a> · <a href="https://support.google.com/a/answer/174124">Google DKIM setup</a> · <a href="https://developers.cloudflare.com/dns/manage-dns-records/reference/dns-record-types/">Cloudflare TXT records</a></p> | ||
| <p><a href="https://www.ftc.gov/business-guidance/resources/can-spam-act-compliance-guide-business">FTC CAN-SPAM guide</a> · <a href="https://support.google.com/a/answer/174124">Google DKIM setup</a> · <a href="https://developers.cloudflare.com/email-service/concepts/email-authentication/">Cloudflare email authentication</a> · <a href="https://developers.cloudflare.com/dns/manage-dns-records/reference/dns-record-types/">Cloudflare TXT records</a></p> | ||
| </section> | ||
| </main> | ||
| </body> | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🟠 Major | 🏗️ Heavy lift
Use the selector for the actual outbound service.
dkimSelectorfeeds the outbound sender-trust check. Cloudflare documentscf2024-1for Email Routing andcf-bouncefor Email Sending. If Cloudflare Email Sending sends the cold email, this value can validate the routing record and clear the outbound gate incorrectly. Confirm the real sending path before merge. Store separate routing and sending selectors if both services are used. (developers.cloudflare.com)Verification
🤖 Prompt for AI Agents