Repository navigation
fix(public): keep app-page early-access CTA above the fold on phones #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -892,7 +892,22 @@ h4 { | |
| } | ||
|
|
||
| .page-hero-card { | ||
| padding: 36px 0 44px; | ||
| padding: 20px 0 40px; | ||
| } | ||
|
|
||
| /* Keep the primary CTA in the first screen: long app-page H1s must not | ||
| bury the action row below the fold on phones. */ | ||
| .page-hero-card h1 { | ||
| max-width: none; | ||
| font-size: clamp(1.9rem, 6vw, 3rem); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
On a 320×568 viewport (the original iPhone SE size), the 1.9rem minimum still leaves the long Promptly and Drishti headings at roughly four lines; after the mobile header, lead copy, and margins, the primary action lands below the first viewport. The verification only covers widths of 375px and above, so the stated phone fix remains incomplete for narrower supported viewports; add a narrower breakpoint or otherwise compact the app hero at these widths. Useful? React with 👍 / 👎. |
||
| } | ||
|
|
||
| .page-hero-card .page-lead { | ||
| margin-top: 14px; | ||
| } | ||
|
|
||
| .page-hero-card .action-row { | ||
| margin-top: 20px; | ||
| } | ||
|
|
||
| .info-card { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At widths up to 720px, this selector also matches every other secondary-page hero, including
/contact/,/support/,/privacy/, the app support/privacy pages, and the 404 page. Their headings therefore drop from the existing 3.4rem minimum to 1.9rem on typical phones even though they do not have the long app-page CTA problem, causing a substantial unrelated typography regression; scope this override to the Promptly and Drishti landing heroes, for example via their.app-statusstructure or a dedicated class.Useful? React with 👍 / 👎.