-
Notifications
You must be signed in to change notification settings - Fork 0
fix(public): restore Promptly support heading hierarchy #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,6 +15,10 @@ const LOOM = "https://www.loom.com/share/1234567890abcdef1234567890abcdef" | |
| const {equal: eq, deepEqual: deq, notEqual: neq, match: mat, doesNotMatch: dnm, ok} = assert | ||
| const trackedArtifactDate = readFileSync(join(C, "growth-brain/ops/proof-library.md"), "utf8").match(/^Generated:\s*(\d{4}-\d{2}-\d{2})$/m)?.[1] | ||
| if (!trackedArtifactDate) throw new Error("Tracked proof library must contain a Generated YYYY-MM-DD date") | ||
| const promptlySupport = readFileSync(join(C, "public/promptly/support/index.html"), "utf8") | ||
| const promptlySupportHeadings = [...promptlySupport.matchAll(/<h([1-3])\b/gi)].map(match => Number(match[1])) | ||
| ok(promptlySupportHeadings.indexOf(2) > promptlySupportHeadings.indexOf(1), "Promptly support must introduce H2 content after its H1") | ||
| ok(!promptlySupportHeadings.slice(promptlySupportHeadings.indexOf(1) + 1).some((level, index, levels) => level === 3 && (index === 0 || levels[index - 1] < 2)), "Promptly support must not skip H2 before content H3 headings") | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
If either the second or third content-card heading regresses to Useful? React with 👍 / 👎. |
||
| const fixedClockImport = pathToFileURL(sp("lib/test-fixed-clock.mjs")).href | ||
| const retiredSurfacePattern = | ||
| /npm run\s+owned:|npm run\s+(?:retention:checkups|client:weekly-loop|value:stress)|client brain|convert a won prospect|filled weekly report|won sprint\(s\) with close package and won note|(?:weekly|full-stack) growth desk|weekly client value loop|every closed deal becomes a client sprint folder|convert the prospect into a client sprint folder/i | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At every viewport, changing these elements to
h2also changes their presentation: the globalh2rule inpublic/styles.css:212-216uses a 2.2–4.2rem size and a 12ch maximum width, whereas these cards previously received the 1.65–2.35remh3size and the.info-card h3spacing inpublic/styles.css:218-220,703-705. Consequently all three card headings become substantially larger and reflow, despite this change's stated semantic-only outcome; add equivalent card-scoped styling for the promotedh2elements.Useful? React with 👍 / 👎.