fix(deploy): accept CLOUDFLARE as the token secret name - #198
Conversation
…UDFLARE_API_TOKEN
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Free Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe public-site deployment workflow now supports ChangesCloudflare secret handling
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to This localized workflow change accepts the provisioned CLOUDFLARE secret name while retaining the documented name as preferred; no actionable merge-blocking risk remains beyond normal checks and review. Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
…-08-20) (#210) The soft-404 defect (unknown URL returns HTTP 200 with the homepage body) is now fixed on https://tinystudio.in: a random nonce URL returns HTTP 404 with the real 'Page not found' page (title 'Page not found • Tiny Studio', H1 'This page could not be found.', noindex meta, shared header/footer chrome, no canonical to '/'). The dedicated live soft-404 checker passes 18/18 and the static unit test passes 21/21. Previous 2026-08-17 reverify (PR #189) concluded the soft-404 was real and live, blocked on the missing CLOUDFLARE_API_TOKEN. The deploy lane has since been repaired end-to-end: - PR #198: workflow reads secrets.CLOUDFLARE_API_TOKEN || secrets.CLOUDFLARE - PR #199: PAGES_PROJECT = 'tiny-studio' (was the broken 'tiny-studio-3f5' subdomain), wrangler --project-name fixed - PR #208: CF_API_BASE /api/v4 -> /client/v4 (captureProductionIdentity was 403'ing on every call since the lane was created) With the lane able to capture a real canonical_deployment, the daily schedule + the next main push published the filtered public/ bundle, and the live 404 page now appears. Live evidence (curl, live checker, deploy acceptance section C, deploy-bundle gate) all agree; item is closed on the live proof, not a code task. Report only; no source file changed. Files: + .lane/reports/docs-lane1-soft-404-reverify-20260820.md Co-authored-by: minimax-vps <minimax-vps@MiniMax.local>
1 participant
Owner provisioned the Pages token under secret name CLOUDFLARE instead of CLOUDFLARE_API_TOKEN. The lane now accepts either (documented name wins when both exist); fail-loud message updated.
Summary by CodeRabbit