test(public): guard public pages against launch-prep footer copy regression - #151
Conversation
…ession PR #35 replaced the launch-prep footer line ('gives each product a clean public foundation before launch') with visitor-facing copy on all twelve shared-footer pages, but shipped without a regression test. Add test-public-footer-copy.mjs, wired into npm test and npm run ci, which fails if any public page's footer block re-introduces launch-prep phrasing or drops the product-naming visitor copy.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Free Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change adds a public-footer copy validation script. The script checks 12 public pages for required product names and forbidden launch-preparation phrases. The ChangesPublic footer validation
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR adds automated protection against a public footer-copy regression without changing production behavior; no actionable merge-blocking risk remains after normal checks and review. Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
package.json conflict only: take main ci/test chains and re-insert this PR own check. The added guard was run against current main content and passes.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
Automated conflict resolution during the PR backlog sweep: kept main's side of every shared block, re-applied this branch's unique additions on top (package scripts re-inserted into main's chains; live-check sections relabelled to the next free letter). Repo check chain re-run green before push.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
1 participant
PR #35 replaced the launch-prep footer line ('gives each product a clean
public foundation before launch') with visitor-facing copy on all twelve
shared-footer pages, but shipped without a regression test. Add
test-public-footer-copy.mjs, wired into npm test and npm run ci, which
fails if any public page's footer block re-introduces launch-prep
phrasing or drops the product-naming visitor copy.
Lane 1: closes the queue item '[unreviewed-by-opus] Eleven public pages still
end with launch-prep footer copy ('clean public foundation before l' by
guarding against the same regression on the 12 shared-footer pages that
PR #35 fixed.
Verification:
Summary by CodeRabbit
Bug Fixes
Tests