Skip to content

fix: restore deterministic service verification gate - #12

Merged
nish3451 merged 1 commit into
mainfrom
nightly/verification-gate-date-fix
Aug 7, 2026
Merged

fix: restore deterministic service verification gate#12
nish3451 merged 1 commit into
mainfrom
nightly/verification-gate-date-fix

Conversation

@nish3451

@nish3451 nish3451 commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Intended outcome

Restore a green repository verification gate across date rollover without weakening product truth, human review, or claim-safety protections.

What changed

  • Propagate the frozen fixture clock to every dashboard-CWD child process so regenerated artifacts cannot be stamped with the wall-clock date.
  • Reword one generated Loom sentence that falsely trips the existing outcome-claim guard because the offer name contains Revenue.
  • Recognize the canonical comma-separated no-guarantee disclaimer and add a regression case.

Verification

  • verify: npm test (passed; 38 checks and all downstream suites)
  • verify: npm run ci (passed)
  • verify: git diff --check (passed)
  • verify: Grok review (ship; no required repair)
  • sgscan: existing baseline warnings only; no diff findings

No deployment, migration, pricing, auth, payment, lead, dependency, or lockfile changes.

Summary by CodeRabbit

  • Bug Fixes

    • Improved guarantee-risk scanning to correctly handle comma-separated and hyphenated forbidden outcome terms in no-guarantee statements.
  • Tests

    • Added coverage for explicit claims involving revenue, rankings, ROAS, conversions, booked calls, and sales volume.
    • Standardized test environments for more consistent results across prospect, dashboard, and command-center checks.
  • Content

    • Refined recording script wording to present the offer as the “obvious next step.”

intended-outcome: keep the repository gate green across date rollover while preserving product-truth and claim-safety protections.\nverify: npm test; npm run ci; git diff --check\n\nCo-Authored-By: Claude <noreply@anthropic.com>

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9531d74e-dd42-4e75-84b4-33531bfdbbe1

📥 Commits

Reviewing files that changed from the base of the PR and between 24e516a and e39b64e.

📒 Files selected for processing (4)
  • scripts/draft-loom-recording-script.mjs
  • scripts/lib/service-artifacts.mjs
  • scripts/test-active-operator-surfaces.mjs
  • scripts/test-service-engine.mjs

📝 Walkthrough

Walkthrough

The changes expand no-guarantee clause filtering, add claim coverage, centralize subprocess test environments, and update recording-script wording.

Changes

Guarantee filtering

Layer / File(s) Summary
Listed guarantee clause filtering
scripts/lib/service-artifacts.mjs, scripts/test-service-engine.mjs
The scanner recognizes comma-separated denial terms and removes them before guarantee analysis. Tests add revenue, ranking, ROAS, conversion, booked-call, and sales-volume claims.

Operator surface updates

Layer / File(s) Summary
Fixed test environment and script wording
scripts/test-active-operator-surfaces.mjs, scripts/draft-loom-recording-script.mjs
Subprocess tests use shared fixed environment settings. The recording goal describes the offer as the obvious next step.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: restoring deterministic service verification across date rollovers.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch nightly/verification-gate-date-fix

Comment @coderabbitai help to get the list of available commands.

@nish3451
nish3451 merged commit ac745bd into main Aug 7, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant