docs(evidence): close out render-blocking finding b8f6046e942a (already fixed in #20/#23, re-verified on current main + live) - #35
Merged
Conversation
…t current main and live The code-side fix (PR #20) and CI enforcement (PR #23) for dogfood finding b8f6046e942a ("Render-blocking resources on home") are already merged in origin/main. This lane re-verified the guarantee still holds after the subsequent page edits (heading hierarchy, apple-touch icon, schema.org, meta descriptions, canonical URLs, internal-link cleanup, App Store citation): - npm run check:render-blocking passes on all six pages (real Chromium, production CSP, css2 delayed 2500ms): css2 non-blocking, first paint never waits for it, no render-blocking resources other than the site's own same-origin stylesheets. - Fresh live measurement of the deployed pages confirms the same: css2 non-blocking on all six pages, only same-origin stylesheets render-block, fonts still load and apply under the production CSP. Nothing further to change; the receipt now records the closeout on the current head so the finding cannot be re-opened by tracker drift.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
📝 WalkthroughWalkthroughThe change adds closeout verification for font loading on six public pages. It records passing CI checks and live Chromium measurements for non-blocking fonts, independent first paint, CSP-compatible stylesheet promotion, and approved render-blocking stylesheets. ChangesFont Loading Verification
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/evidence/render-blocking-fonts-2026-08-08.md`:
- Around line 152-157: Update the six-page PASS summary to label the third page
as agents, matching the documented agents.html scope and live results;
alternatively clarify that desk is the display name for agents.html while
preserving the 56ms FCP value.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: be12cdd4-f8c3-4e33-a981-e8855a3eedbc
📒 Files selected for processing (1)
docs/evidence/render-blocking-fonts-2026-08-08.md
Comment on lines
+152
to
+157
| 1. `npm run check:render-blocking` on the current working tree (real Chromium, | ||
| production CSP, css2 intercepted and delayed 2500ms, stubbed response): all | ||
| six pages PASS — css2 non-blocking, first-contentful-paint never waits for it | ||
| (homepage 320ms, audit 84ms, desk 56ms, pricing 52ms, specimen 72ms, | ||
| brief-requested 68ms), no render-blocking resources other than the site's | ||
| own same-origin stylesheets, promoted sheet applied. |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Use the correct page name in the PASS summary.
The summary labels the third page as desk, but the documented six-page scope and live results use agents.html. This makes the 56ms FCP value ambiguous. Replace desk with agents, or state that desk is the display name for agents.html.
Proposed fix
- (homepage 320ms, audit 84ms, desk 56ms, pricing 52ms,
+ (homepage 320ms, audit 84ms, agents 56ms, pricing 52ms,📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| 1. `npm run check:render-blocking` on the current working tree (real Chromium, | |
| production CSP, css2 intercepted and delayed 2500ms, stubbed response): all | |
| six pages PASS — css2 non-blocking, first-contentful-paint never waits for it | |
| (homepage 320ms, audit 84ms, desk 56ms, pricing 52ms, specimen 72ms, | |
| brief-requested 68ms), no render-blocking resources other than the site's | |
| own same-origin stylesheets, promoted sheet applied. | |
| 1. `npm run check:render-blocking` on the current working tree (real Chromium, | |
| production CSP, css2 intercepted and delayed 2500ms, stubbed response): all | |
| six pages PASS — css2 non-blocking, first-contentful-paint never waits for it | |
| (homepage 320ms, audit 84ms, agents 56ms, pricing 52ms, specimen 72ms, | |
| brief-requested 68ms), no render-blocking resources other than the site's | |
| own same-origin stylesheets, promoted sheet applied. |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/evidence/render-blocking-fonts-2026-08-08.md` around lines 152 - 157,
Update the six-page PASS summary to label the third page as agents, matching the
documented agents.html scope and live results; alternatively clarify that desk
is the display name for agents.html while preserving the 56ms FCP value.
This was referenced Aug 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR is
Dogfood finding b8f6046e942a ("Render-blocking resources on home", dogfood run 20260808T074205Z-msk2fl3n) was already resolved in origin/main before this lane started:
c5599bc): Google Fonts css2 loaded non-blocking on all six public pages via preload + same-originfonts.jspromotion +<noscript>fallback;@importchain removed fromshared.css;/fonts.jsallow-listed in the worker.5bf97f2):npm run check:render-blockingbrowser step in.github/workflows/ci.yml.What this lane verified (2026-08-09, against current main
a163327)npm test— all suites green (check-site 6/6, headings 53/53, worker 15/15, UI).npm run check:render-blocking— real Chromium under the production CSP with the css2 response delayed 2500ms: all six pages PASS (css2 non-blocking, FCP never waits, only same-origin stylesheets render-block, promoted sheet applies).Change
Single docs file: the evidence receipt
docs/evidence/render-blocking-fonts-2026-08-08.mdgains a closeout section recording the re-verification on the current head, so the finding cannot be re-opened by tracker drift. No code change was needed or made — the fix was already merged.Closes dogfood item b8f6046e942a.
Summary by CodeRabbit