docs(evidence): re-verify Google Ads conversion placeholder close-out on current main and live (2026-08-15, lane 1) - #233
Conversation
… on current main and live (2026-08-15, lane 1)
Re-verifies item d2c8a852ff ("The funnel's only Google Ads conversion
measurement is dead by construction: placeholder tag") against current
origin/main (c62211c) and the live deployment. The fix from PR #172
(60d045c) still holds: no commit since the #227/#228 close-out touched
the ads surface, npm run check passes including the Google Ads guard,
npm test passes end to end (worker 80/80 incl. the three ads-tag tests),
and the live /brief-requested serves no tag with the strict CSP while
the env values are unconfigured. Finding stays closed — no code change.
Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
Warning Review limit reached
Next review available in: 25 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Free Run ID: 📒 Files selected for processing (2)
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
1 participant
Re-verifies item
d2c8a852ff— The funnel's only Google Ads conversion measurement is dead by construction: placeholder tag.Verdict
Finding stays closed — no code change required. The dead-by-construction shape was removed by PR #172 (
60d045c, merged 2026-08-13) and this lane re-confirms the close-out on the currentorigin/mainhead (c62211c) and the live deployment (2026-08-15).Evidence
23e24d6) touchedsrc/worker.js,public/brief-requested.html,public/brief-requested.js,scripts/check-site.mjsorspecs/003-wellness-clinic-launch/tracking-setup.md.git merge-base --is-ancestor 60d045c HEAD→ yes.npm run checkpasses, including the "Google Ads conversion tag" guard (placeholder scan, no hardcoded gtag in public files, env-driven wiring present).npm testpasses end to end: worker 80/80 incl. the three ads-tag tests (no tag + strict CSP while unconfigured; injected loader + generated script + page-scoped CSP when configured; nothing for partial/malformed config) — zero failures across all suites./brief-requested→ 200 with the strict CSP and zerogoogletagmanager/AW-references;/brief-requested.js→ 200 static no-op.With the secrets unset the funnel ships zero tracking rather than a dead tag, and the tag activates from env with no code change once the real conversion ID/label are set via
wrangler secret put.Evidence:
docs/evidence/ads-conversion-placeholder-rereverify-2026-08-15-lane1.md