-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any plans to comply with toml v1.0.0? #40
Comments
Thanks for the notification, we should definitely update this to be compatible with v1.0.0. EDIT: I can see that it's still a release candidate, but we should start working towards it anyways. Historically the test suite for TOML is always lagging behind though, so it's not the easiest task in the world. |
Version 1.0.0 has been released since the beginning of the year. |
Any test-suite yet that we can work against? EDIT: For reference this is the one I've used to verify the parser against thus far: https://github.com/BurntSushi/toml-test |
@PMunch This seems to be the latest test suite: https://github.com/iarna/toml-spec-tests |
Hmm, with that one we need to implement a YAML output writer as well |
I noticed that the Burntsushi toml-test project has now a new maintainer and it's updated to include TOML v1.0.0 tests. To install:
With that, I am now getting 49 fails.
|
* GHA: Set GOPATH * GHA: Print go version * GHA: Attempt to fix GOPATH https://laszlo.cloud/setting-gopath-in-github-actions * GHA: Attempt 2 to fix GOPATH https://github.com/golang/go/wiki/SettingGOPATH#go-113 * GHA: Try getting rid of GOPATH * GHA: Install toml-test * GHA: Require go version 1.16.5 This was the latest stable go version when this was committed. * GHA: Fix .yml * GHA: Specify the version of toml-test to be installed * GHA: Separate 'uses' and 'run' Looks like GHA doesn't work if both are in the same yml node. * GHA: Looks like we do need to set GOPATH * GHA: Install an older version of toml-test that installs binary * Update to use tests for TOML 1.0.0 * GHA: Add skips for failing TOML v1.0.0 tests Ref: #40 * GHA: Disable testing on macos It fails with these errors: go: writing stat cache: mkdir /home/runner: operation not supported go: writing stat cache: mkdir /home/runner: operation not supported go: downloading github.com/BurntSushi/toml-test v0.1.1-0.20210628215546-8c0aa6d9c74f go get github.com/BurntSushi/toml-test/cmd/toml-test@master: mkdir /home/runner: operation not supported stack trace: (most recent call last) /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/nimblecache-946033505/nimscriptapi_610282258.nim(187, 16) /Users/runner/work/parsetoml/parsetoml/parsetoml.nimble(36, 7) run_toml_test_with_skipsTask /Users/runner/work/parsetoml/parsetoml/nim/lib/system/nimscript.nim(273, 7) exec /Users/runner/work/parsetoml/parsetoml/nim/lib/system/nimscript.nim(273, 7) Error: unhandled exception: FAILED: go get -u -v github.com/BurntSushi/toml-test/cmd/toml-test@master [OSError] * Add few comments about incompatibility with TOML v1.0.0 * GHA: Disable testing on Windows * GHA: Get rid of GOPATH dependency Assumption is that $GOPATH/bin is auto-added to $PATH. * Skip a test for now; it's failing on Windows Ref: - #51 - https://github.com/NimParsers/parsetoml/pull/50/checks?check_run_id=2966348113
Ref: 83de3f3 Now this passes
This issue can be closed once |
Hey, toml has reached version 1. Anyone up for adjusting this project to be consistent with it?
The text was updated successfully, but these errors were encountered: