Skip to content

Conversation

@manel1874
Copy link
Contributor

@manel1874 manel1874 commented Oct 14, 2024

This is just a preliminary example for shuffling a vector without any constraint in size. We want to greatly improve on this but we can have it as an example for reference before we include it under nada-numpy.

Note: The example does not support arrays with Rational or SecretRational types.

Optimizations for future reference:

  1. Add support for random boolean in nada dsl directly,
  2. Avoid truncation,
  3. Add support for one_hot_vector as a preprocessing element from nada dsl.

@manel1874 manel1874 requested review from a user, jcabrero and jimouris October 14, 2024 15:27
Copy link
Member

@jcabrero jcabrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me 👍 . Just one small comment, in tests/test_all.py, add this example to the list EXAMPLES. In that way, we test all examples with the CI and ensure they all work with the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants