Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - Generic file writer #54

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

riccamini
Copy link
Contributor

Generic file writer

Description

This PR provides a generic FileWriter class for several file formats and can be configured with any required option

Related Issue

#52

Motivation and Context

Koheesio is currently shipping with the FileLoader which allows to read any file format specifying any needed option. The same feature, on the other hand, is missing on the writer side as there's no current class that supports generic file writing

How Has This Been Tested?

Unit tests with mocks for DataFrameWriter calls

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@riccamini riccamini requested a review from a team as a code owner July 9, 2024 07:39
src/koheesio/spark/writers/file_writer.py Outdated Show resolved Hide resolved
src/koheesio/spark/writers/file_writer.py Outdated Show resolved Hide resolved
src/koheesio/spark/writers/file_writer.py Outdated Show resolved Hide resolved
src/koheesio/spark/writers/file_writer.py Outdated Show resolved Hide resolved
src/koheesio/spark/writers/file_writer.py Outdated Show resolved Hide resolved
src/koheesio/spark/writers/file_writer.py Outdated Show resolved Hide resolved
src/koheesio/spark/writers/file_writer.py Outdated Show resolved Hide resolved
src/koheesio/spark/writers/file_writer.py Outdated Show resolved Hide resolved
@riccamini
Copy link
Contributor Author

@dannymeijer Hope now it renders well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants