Make the Redis broker clean up aborted jobs #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Redis broker uses a non-zero value for `max_retries` to determine if it should remove a job from the "running" state. So when an `AbortException` is thrown, max out the `job.retries` counter, rather than zeroing out the `job.max_retries` counter. This will have the same effect, but play more nicely with what the Redis broker is expecting. The MemoryBroker is unaffected by this. Fixes Issue NicolasLM#20
bigjools
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Redis broker uses a non-zero value for
max_retriesto determine if it should remove a job from the "running" state. So when anAbortExceptionis thrown, max out thejob.retriescounter, rather than zeroing out thejob.max_retriescounter. This will have the same effect, but play more nicely with what the Redis broker is expecting.The MemoryBroker is unaffected by this.
Fixes Issue #20