Return Jobs when scheduling them #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xDEC0DE
suggested changes
Apr 28, 2022
Comment on lines
-221
to
227
| self._spin.schedule(task, *args, **kwargs) | ||
| return self._spin.schedule(task, *args, **kwargs) | ||
|
|
There was a problem hiding this comment.
This method signature and docstring should also be updated to reflect the new return value.
Comment on lines
-238
to
+247
| self._spin.schedule_at(task, at, *args, **kwargs) | ||
| return self._spin.schedule_at(task, at, *args, **kwargs) |
Comment on lines
-249
to
+260
| self._spin.schedule_batch(batch) | ||
| return self._spin.schedule_batch(batch) |
Engine.schedule* and Task.schedule* used to return None, now they will return the Job(s) actually scheduled. Fixes NicolasLM#21
0xDEC0DE
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Engine.schedule* and Task.schedule* used to return None, now they will
return the Job(s) actually scheduled.
Fixes #21