Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View Download Logs + Minor Fixes #64

Merged
merged 45 commits into from
Mar 2, 2023
Merged

View Download Logs + Minor Fixes #64

merged 45 commits into from
Mar 2, 2023

Conversation

nlogozzo
Copy link
Member

@nlogozzo nlogozzo commented Mar 1, 2023 •
edited
Loading

This PR implements the ability to view logs of a download as it is occurring.

Closes #40

image
image

Todo

  • Delete log files when the application is closed
  • Fix GNOME scrolling to the end of the logs section (currently it scrolls to the last log - 1)
  • NOT BLOCKING -- Wait for yt-dlp to release the slowness fix (Youtube get URL with slow speed download yt-dlp/yt-dlp#6369 (comment))
  • Start more downloads in the queue if Max Number of Active Downloads increased

@nlogozzo nlogozzo added this to the V2023.3.0 milestone Mar 1, 2023
@nlogozzo nlogozzo marked this pull request as ready for review March 1, 2023 13:45
@nlogozzo nlogozzo requested review from fsobolev and DaPigGuy March 1, 2023 13:45
@DaPigGuy DaPigGuy mentioned this pull request Mar 1, 2023
Closed
@nlogozzo nlogozzo changed the title View Download Logs View Download Logs + Minor Fixes Mar 2, 2023
@nlogozzo nlogozzo marked this pull request as draft March 2, 2023 03:42
@nlogozzo nlogozzo removed the request for review from DaPigGuy March 2, 2023 03:42
nlogozzo and others added 21 commits March 1, 2023 23:03
@nlogozzo
GNOME - Update Log In Processing
6d2098d
@fsobolev
GNOME - Make log text selectable
fa86aed
@nlogozzo
WinUI - Make log text selectable
b90858c
@nlogozzo
Shared - Set Stderr To Output File
6e00e2c
@nlogozzo
All - (WIP) Pull Downloads From Queue On MaxNumberOfActiveDownlaods C…
92fc1ae 
…hanged
@fsobolev
GNOME - Fix postprocess logging
b50a249
@DaPigGuy
GNOME - Fix missing width request on main window
b7e1736
@DaPigGuy
Shared - Remove pointless _numberOfActiveDownloads field
dc96ce0
@fsobolev
GNOME - Fix log scrolling
c9d798b
@DaPigGuy
Shared - Use switch in place of if/else if for greeting
f02c036
@DaPigGuy
GNOME - Clean up some code dupe in MoveDownloadRow
c87e942
@DaPigGuy
GNOME - Further clean up MoveDownloadRow
7da99d5 
https://media.tenor.com/0engAwwUVF4AAAAC/more-kylo-ren.gif
@DaPigGuy
GNOME - Fix download row move leaving proceding separator
79c1d4d 
Also more code cleanup... MORE!
@nlogozzo
Merge branch 'main' into view-logs
9840c61
@nlogozzo
GTK - Fix Logs In Callbacks
657acea
@fsobolev
GNOME - Fix scrolling during postprocessing
599780f
@fsobolev
GNOME - Set log visibility using bind in blp
c2f3528
@fsobolev
GNOME - Copy log to clipboard
1a56619
@fsobolev
GNOME - Better justfile
c19235c 
NickvisionApps/Application#45
@fsobolev
GNOME - Move copy log button
bb0bff4
@nlogozzo
GNOME - Better Notifications in DownloadRow
e5ce72d
@nlogozzo
Copy link
Member Author

nlogozzo commented Mar 2, 2023

Wait for yt-dlp to release the slowness fix (yt-dlp/yt-dlp#6369 (comment))

Probably not going to have this block the release of beta2, since there is no new release yet. Won't release stable until this yt-dlp release is out...but we still have time before TC stable

@nlogozzo nlogozzo marked this pull request as ready for review March 2, 2023 20:40
@nlogozzo nlogozzo requested a review from fsobolev March 2, 2023 20:40
@fsobolev fsobolev merged commit 2934b8c into main Mar 2, 2023
@fsobolev fsobolev deleted the view-logs branch March 2, 2023 20:42
@nlogozzo nlogozzo added feature New feature or request in-beta This issue is fixed in a beta version labels Mar 4, 2023
@nlogozzo
Copy link
Member Author

nlogozzo commented Mar 4, 2023

https://github.com/nlogozzo/NickvisionTubeConverter/releases/tag/2023.3.0-beta2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsobolev fsobolev fsobolev approved these changes

Assignees
No one assigned
Labels
feature New feature or request in-beta This issue is fixed in a beta version
Projects
None yet
Milestone
V2023.3.0
Development

Successfully merging this pull request may close these issues.

Show download log while downloading a video
3 participants
@nlogozzo @fsobolev @DaPigGuy