Testing reviewdog warnings#24
Closed
NickSzapiro-NOAA wants to merge 12 commits into
Closed
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds several warning flags (-Wall, -Wextra, and -Wimplicit-interface) to the Fortran debug configuration in cmake/GNU.cmake. The reviewer noted that these flags may cause significant build warnings or failures in a large codebase, particularly if warnings are treated as errors, and suggested splitting the flags into multiple lines for improved readability.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
| INTEGER :: resultlen | ||
| ! | ||
| INTEGER :: RC, RC_USER !<-- The running error signal | ||
| INTEGER :: reviewdog_test_unused_var ! ---> DELIBERATE WARNING FOR REVIEWDOG TEST |
There was a problem hiding this comment.
[New PR Warnings] reported by reviewdog 🐶
Unused variable 'reviewdog_test_unused_var' declared at (1) [-Wunused-variable]
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Queue Requirements:
test_changes.listindicates which tests, if any, are changed by this PR. Committest_changes.list, even if it is empty.Description:
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Documentation:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: