Skip to content

Testing reviewdog warnings#24

Closed
NickSzapiro-NOAA wants to merge 12 commits into
developfrom
try_reviewdog_warnings
Closed

Testing reviewdog warnings#24
NickSzapiro-NOAA wants to merge 12 commits into
developfrom
try_reviewdog_warnings

Conversation

@NickSzapiro-NOAA

Copy link
Copy Markdown
Owner

Commit Queue Requirements:

  • This PR addresses a relevant WM issue (if not, create an issue).
  • All subcomponent pull requests (if any) have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
    • Commit log file w/full results from RT suite run (if applicable).
    • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
  • Fill out all sections of this template.

Description:

Commit Message:

* UFSWM - 
  * AQM - 
  * CDEPS - 
  * CICE - 
  * CMEPS - 
  * CMakeModules - 
  * UFSATM - 
    * ccpp-physics - 
    * atmos_cubed_sphere - 
  * GOCART - 
  * MOM6 - 
  * NOAHMP - 
  * WW3 - 
  * fire_behavior
  * stochastic_physics - 

Priority:

  • Critical Bugfix: Reason
  • High: Reason
  • Normal

Git Tracking

UFSWM:

  • Closes #

Sub component Pull Requests:

  • AQM:
  • CDEPS:
  • CICE:
  • CMEPS:
  • CMakeModules:
  • UFSATM:
    • ccpp-physics:
    • atmos_cubed_sphere:
  • GOCART:
  • MOM6:
  • NOAHMP:
  • WW3:
  • fire_behavior:
  • stochastic_physics:
  • None

UFSWM Blocking Dependencies:

  • Blocked by #
  • None

Documentation:

  • Documentation update required.
    • Relevant updates are included with this PR.
    • A WM issue has been opened to track the need for a documentation update; a person responsible for submitting the update has been assigned to the issue (link issue).
  • Documentation update NOT required.
    • Explanation:

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.
  • PR Updates/Changes Baselines.
  • No Baseline Changes.

Input data Changes:

  • None.
  • PR adds input data.
  • PR changes existing input data.

Library Changes/Upgrades:

  • Required
    • Library names w/versions:
    • Git Stack Issue (JCSDA/spack-stack#)
  • No Updates

Testing Log:

  • RDHPCS
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds several warning flags (-Wall, -Wextra, and -Wimplicit-interface) to the Fortran debug configuration in cmake/GNU.cmake. The reviewer noted that these flags may cause significant build warnings or failures in a large codebase, particularly if warnings are treated as errors, and suggested splitting the flags into multiple lines for improved readability.

Comment thread cmake/GNU.cmake Outdated
NickSzapiro-NOAA and others added 3 commits April 14, 2026 10:45
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Comment thread driver/UFS.F90
INTEGER :: resultlen
!
INTEGER :: RC, RC_USER !<-- The running error signal
INTEGER :: reviewdog_test_unused_var ! ---> DELIBERATE WARNING FOR REVIEWDOG TEST

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[New PR Warnings] reported by reviewdog 🐶
Unused variable 'reviewdog_test_unused_var' declared at (1) [-Wunused-variable]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant