Skip to content

fix issue for heterogenuous block_size and layout #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NickLucche merged 1 commit into from
Jan 13, 2026
Merged

fix issue for heterogenuous block_size and layout #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions vllm/distributed/kv_transfer/kv_connector/v1/nixl_connector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1875,7 +1875,7 @@ def get_finished(self) -> tuple[set[str], set[str]]:
block_size_ratio > 1 or self.enable_permute_local_kv
):
block_ids_for_blocksize_post_process[block_size_ratio].append(
meta.local_physical_block_ids
meta.local_physical_block_ids[0]
)
for (
block_size_ratio,
Expand Down Expand Up @@ -2151,7 +2151,7 @@ def _read_blocks(
remote_block_ids = remote_block_ids[0]
local_block_ids = self.get_mapped_blocks(
np.asarray(local_block_ids), block_size_ratio
)
).tolist()
if len(local_block_ids) > len(remote_block_ids):
# NOTE:
# get_mapped_blocks will always expand block_ids for n times.
Expand All @@ -2165,8 +2165,8 @@ def _read_blocks(
# [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12] to
# [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
local_block_ids = local_block_ids[: len(remote_block_ids)]
local_block_ids = tuple(local_block_ids) if local_block_ids else []
remote_block_ids = tuple(remote_block_ids)
local_block_ids = [local_block_ids] if local_block_ids else []
remote_block_ids = [remote_block_ids]
# NOTE(rob): having the staging blocks be on the READER side is
# not going to work well (since we will have to call rearrange tensors).
# after we detect the txn is complete (which means we cannot make the
Expand Down