[NIXL][Metrics] Fix NIXL buckets#6
Merged
NickLucche merged 1 commit intoNickLucche:nixl-prometheusfrom Oct 24, 2025
Merged
Conversation
It's post times that need the smaller bucket size, not transfer duration. Uniform 2kb to 16gb range: ``` >>> def human_size(bytes, units=[' bytes','KB','MB','GB','TB', 'PB', 'EB']): ... """ Returns a human readable string representation of bytes """ ... return str(bytes) + units[0] if bytes < 1024 else human_size(bytes>>10, units[1:]) ... >>> [human_size(2**(10+i)) for i in range(1, 25, 2)] ['2KB', '8KB', '32KB', '128KB', '512KB', '2MB', '8MB', '32MB', '128MB', '512MB', '2GB', '8GB'] ``` Signed-off-by: Mark McLoughlin <markmc@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per comments in vllm-project#26811
It's post times that need the smaller bucket size, not transfer duration.
Uniform 2kb to 16gb range: