security: enforce HTTPS-only redirects in staging deploy script curl downloads#285
Merged
Merged
Conversation
4 tasks
…calls Replace `curl -fsSL` with `curl --fail --show-error --silent --location --proto '=https' --tlsv1.2` for both public GitHub binary downloads (sops and age) in STAGING_FIRST_DEPLOY.sh. This resolves SonarCloud shell:S6506 hotspots on lines 144 and 162 by preventing curl from following redirects to non-HTTPS URLs. Add inline comments explaining the HTTPS restriction for each call. Shellcheck exits 0 on the modified script. Agent-Logs-Url: https://github.com/NickLetts2/Curvit/sessions/fa1b3a40-7840-4a00-81b7-eb544de09b98 Co-authored-by: NickLetts2 <90337962+NickLetts2@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix HTTPS redirect handling in staging deploy script
security: enforce HTTPS-only redirects in staging deploy script curl downloads
May 15, 2026
NickLetts2
added a commit
that referenced
this pull request
Jun 1, 2026
…-script security: enforce HTTPS-only redirects in staging deploy script curl downloads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
curl -fsSLin the staging bootstrap script follows redirects without protocol restriction, allowing a potential downgrade from HTTPS to HTTP mid-redirect (SonarCloudshell:S6506, lines 144 and 162).Changes
scripts/STAGING_FIRST_DEPLOY.sh— both binary download calls (sops, age) hardened:-fsSLshorthand with explicit--fail --show-error --silent --location --proto '=https' --tlsv1.2--proto '=https'blocks any redirect that would leave HTTPS--tlsv1.2enforces minimum TLS version on the connectionBoth download targets are public GitHub release endpoints; no local/internal HTTP checks are present in this script, so
--proto '=https'is the correct and complete remedy for both hotspots.