Replace Binding<String?> by String? for read-only access #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm super new to SwiftUI so I may have understood it wrong, anyway I found that opening a PR might be the fastest way to answer my question. This project still works for me after these changes - my badge still updates fine if I make it a
let
(immutable read-only) instead of passing in a Binding. https://swiftuipropertywrappers.com seems to suggest that approach when write access isn't needed.Are there scenarios where Binding is needed here?
Thank you!
PS.: the practical reason why I didn't want to inject a Binding was that I wanted the badge to be computed from an @EnvironmentObject instead of having yet another property (probably a @State) that replicates part of that information.