Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to null safety #35

Merged
merged 3 commits into from
Jan 25, 2022
Merged

Migrate to null safety #35

merged 3 commits into from
Jan 25, 2022

Conversation

timekone
Copy link
Contributor

Hi!
Thank you for such a useful package ❤️

I took it upon myself to migrate it to null safety.

  • Replaced the utf package with its null safe fork utf_convert.
  • Removed avoid_as from analysis_options.yaml because avoid_as has been deprecated.
  • Replaced deprecated constructors of List.

Could you review my changes please?

NiKoTron and others added 3 commits August 20, 2020 12:50
utf_convert supports null safety.
Removed avoid_as from analysis_options.yaml because it was deprecated.
@NiKoTron
Copy link
Owner

Hi @timekone! Thanx for this PR and sorry for the late response, I was too busy with a new job.

Everything looks fine, if you don't mind I've changed the target branch to develop.

@NiKoTron NiKoTron changed the base branch from master to develop January 25, 2022 11:00
@NiKoTron NiKoTron merged commit 9f68ec7 into NiKoTron:develop Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants