Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the device list into a separate scroll area #1680

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LorenDB
Copy link
Member

@LorenDB LorenDB commented Feb 5, 2024

Scrolling the device list alongside all other user info is not
a very great UX, so I've fixed it.

Scrolling the device list alongside all other user info is not
a very great UX, so I've fixed it.
@deepbluev7
Copy link
Member

This was originally done so that on mobile you can scroll the device list without the profile taking up screen space. Are you sure we should revert that?

@LorenDB
Copy link
Member Author

LorenDB commented Feb 15, 2024

Hm, that is a good point. However, I feel like the current design is a significant departure from both our overall UI choices (e.g. the members list) and general consensus in most apps' UI choices. Also, I think that most people rarely need to check a device list anyway, so this isn't a huge problem to start with.

@deepbluev7
Copy link
Member

It is pretty common on mobile apps to have this in one scrollable section and I think Element used to do that as well, so I am not sure it is that much of a departure?

@LorenDB
Copy link
Member Author

LorenDB commented Feb 23, 2024

Well, you can abandon this change if you want, but personally I think it is a little strange that this is the only dialog in nheko where the entire dialog content scrolls rather than just the list content. Maybe there is a better way to solve this though.

@deepbluev7
Copy link
Member

It isn't the only dialog, is it? Both the userprofile and the room profile scroll and are similar in design for me?

@redsky17
Copy link
Member

I'm of the opinion that the only part that should scroll is the actual 'data' that needs to be scrolled... not extraneous additional data on the same page. That being said, the argument for screen real estate on a mobile device is a good one. Perhaps it could be done the existing way on mobile and this new way on desktop?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants