chore: use branch for referencing called workflows instead of commit sha#515
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis pull request updates GitHub Actions workflow files to reference reusable workflows using the ChangesWorkflow reusable ref updates to chore/pnpm-setup
🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
344f294 to
7bc794a
Compare
Deploying sdk with
|
| Latest commit: |
7bc794a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8ed53988.sdk-9yp.pages.dev |
| Branch Preview URL: | https://feat-npm-oicd-use-branch-nam.sdk-9yp.pages.dev |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/prep-next.yml:
- Line 34: The workflow uses a mutable branch ref for the reusable workflow
(uses:
NexusMutual/workflows/.github/workflows/check-version-bump.yml@chore/pnpm-setup),
which must be pinned to an immutable commit SHA; update that `uses:` value to
reference the exact commit SHA of the NexusMutual/workflows repo (replace
`@chore/pnpm-setup` with `@<commit-sha>`) and make the same replacement for the
second occurrence in this file so both references are pinned to immutable SHAs.
In @.github/workflows/release.yml:
- Line 100: The workflow currently references the downstream template by branch:
the line using
"NexusMutual/workflows/.github/workflows/open-pr.yml@chore/pnpm-setup" should be
pinned to a specific commit SHA instead of a branch name; update that reference
to use the exact commit SHA of the intended open-pr.yml commit and (optionally)
add a comment indicating the corresponding release tag or version for
maintainability so future readers know which tag the SHA belongs to.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ca980c2e-ce8f-4907-8396-30054f982815
📒 Files selected for processing (3)
.github/workflows/prep-latest.yml.github/workflows/prep-next.yml.github/workflows/release.yml
We still may push to workflows, this is more flexible up until we merge that PR.
Summary by CodeRabbit