Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

03-pages → 01-building-your-application → 02-rendering → 02-static-site-generation.mdx #407

Merged
merged 2 commits into from
Aug 3, 2023
Merged

03-pages → 01-building-your-application → 02-rendering → 02-static-site-generation.mdx #407

merged 2 commits into from
Aug 3, 2023

Conversation

Junghoon-P
Copy link
Contributor

기여자용

docs: 03-pages > 01- building-your-application > 02 - rendering -> 02 - static-site-generation.mdx 번역

문서 개선

Progress

@Junghoon-P Junghoon-P changed the title docs: Static Site Generation 번역 초안 03-pages → 01- building-your-application → 02-rendering → 02-static-site-generation.mdx Jul 4, 2023
@Junghoon-P Junghoon-P changed the title 03-pages → 01- building-your-application → 02-rendering → 02-static-site-generation.mdx 03-pages → 01-building-your-application → 02-rendering → 02-static-site-generation.mdx Jul 4, 2023
@Junghoon-P Junghoon-P mentioned this pull request Jul 4, 2023
Closed
@devyuriii devyuriii mentioned this pull request Jul 5, 2023
Open
@devyuriii devyuriii linked an issue Jul 5, 2023 that may be closed by this pull request
02-static-site-generation.mdx #38
Closed
@ChanghyeonYoon ChanghyeonYoon added the documentation 문서 작업 label Jul 5, 2023
HA-SEUNG-JEONG
HA-SEUNG-JEONG reviewed Jul 6, 2023
View reviewed changes
docs/03-pages/01-building-your-application/02-rendering/02-static-site-generation.mdx Outdated

By default, Next.js pre-renders pages using Static Generation without fetching data. Here's an example:
기본적으로 Next.js는 데이터를 가져오지 않고 정적 생성을 사용해 페이지를 미리 렌더링합니다. 다음은 예시입니다:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

단어가 pre-renders로 동일한데, 가장 하단에 있는 부분에 나와있는 사전 렌더링과 통일이 필요해 보입니다.

제 의견으로는 사전 렌더링이 더 적합하지 않을까 싶습니다!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HA-SEUNG-JEONG 좋은 것 같습니다! febdcde 반영했습니다.

@Junghoon-P
Copy link
Contributor Author

@HA-SEUNG-JEONG 추가 진행할 사항이 있을까요?

@HA-SEUNG-JEONG
Copy link
Contributor

@HA-SEUNG-JEONG 추가 진행할 사항이 있을까요?

따로 없습니다!

@Junghoon-P
Copy link
Contributor Author

@HA-SEUNG-JEONG 추가 진행할 사항이 있을까요?

따로 없습니다!

머지는 대기하면 될까요?

yoo-jimin127
yoo-jimin127 approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@yoo-jimin127 yoo-jimin127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 수고하셨습니다 :)👍
추가로 번역 희망하시는 문서의 경우 이슈에 작성해주세요 !

@yoo-jimin127 yoo-jimin127 merged commit cda01fa into Nextjs-kr:main Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HA-SEUNG-JEONG HA-SEUNG-JEONG HA-SEUNG-JEONG left review comments

@yoo-jimin127 yoo-jimin127 yoo-jimin127 approved these changes

@ChanghyeonYoon ChanghyeonYoon Awaiting requested review from ChanghyeonYoon ChanghyeonYoon is a code owner

Assignees

@Junghoon-P Junghoon-P

Labels
documentation 문서 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

02-static-site-generation.mdx
4 participants
@Junghoon-P @HA-SEUNG-JEONG @yoo-jimin127 @ChanghyeonYoon