Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate: 02-app > 01-building-your-application > 05-optimizing > 04-metadata #348

Merged

Conversation

bingwer
Copy link
Contributor

@bingwer bingwer commented Jun 29, 2023

@devyuriii
Copy link
Contributor

ref #26

Copy link
Contributor

@sunmerrr sunmerrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 남겼습니다. 확인 부탁드립니다 😃


> **Good to know**:
> **알아두면 좋은 것**:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 부분은 참고 로 번역해주시면 될 것 같습니다.(참고)

@@ -179,12 +179,12 @@ export const metadata = {
// <meta property="og:title" content="Blog" />
```

In the example above:
위의 예제에서는
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example는 예시 로 통일해주시는게 좋을 것 같습니다. (참고)

@bingwer
Copy link
Contributor Author

bingwer commented Jul 18, 2023

@sunmerrr 리뷰 반영 완료했습니다.

@sunmerrr
Copy link
Contributor

sunmerrr commented Jul 18, 2023

@bingwer 확인했습니다:) 수고하셨어요!

Copy link
Contributor

@yoo-jimin127 yoo-jimin127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 수고하셨습니다 :) 👍
추가로 할당 희망하시는 티켓은 이슈에 작성해주셔도 됩니다!!

@yoo-jimin127 yoo-jimin127 merged commit f82e6cf into Nextjs-kr:main Jul 19, 2023
@yoo-jimin127 yoo-jimin127 mentioned this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants