Docs: 02-app > 01-building-your-app-application > 01-routing > 05-dynamic-routes.mdx #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ref #10 |
g2hhh2ee
reviewed
Jul 14, 2023
docs/02-app/01-building-your-application/01-routing/05-dynamic-routes.mdx
Outdated
Show resolved
Hide resolved
docs/02-app/01-building-your-application/01-routing/05-dynamic-routes.mdx
Outdated
Show resolved
Hide resolved
docs/02-app/01-building-your-application/01-routing/05-dynamic-routes.mdx
Outdated
Show resolved
Hide resolved
docs/02-app/01-building-your-application/01-routing/05-dynamic-routes.mdx
Outdated
Show resolved
Hide resolved
docs/02-app/01-building-your-application/01-routing/05-dynamic-routes.mdx
Outdated
Show resolved
Hide resolved
|
|
||
| For example, `app/shop/[[...slug]]/page.js` will **also** match `/shop`, in addition to `/shop/clothes`, `/shop/clothes/tops`, `/shop/clothes/tops/t-shirts`. | ||
| 예를 들어, `app/shop/[[...slug]]/page.js` 는 `/shop/clothes`, `/shop/clothes/tops`, `/shop/clothes/tops/t-shirts` **이외에도** `/shop` 과 일치합니다. |
There was a problem hiding this comment.
Suggested change
| 예를 들어, `app/shop/[[...slug]]/page.js` 는 `/shop/clothes`, `/shop/clothes/tops`, `/shop/clothes/tops/t-shirts` **이외에도** `/shop` 과 일치합니다. | |
| 예를 들어, `app/shop/[[...slug]]/page.js` 는 `/shop` **이외에도** `/shop/clothes`, `/shop/clothes/tops`, `/shop/clothes/tops/t-shirts`와 일치합니다. |
이렇게 수정하는 게 조금 더 매끄러운 것 같아요 :)
There was a problem hiding this comment.
번거로우셨을테지만 제 실수까지 대신 찾아주셔서 정말 감사드립니다..
그런데 이 부분은 optional catch-all 일때는 parmater가 있는 라우터들 '뿐만 아니라'
paramter가 없는 root경로 '까지도' 포함한다는 의미여서 제가 번역한 의미가 맞는 것 같습니다.
There was a problem hiding this comment.
그렇네요! 저도 바로 밑의 문장까지 이어짐을 고려해 /shop을 강조하는 게 맞다고 생각하여 앞쪽으로 배치한 것이었으나 뿐만아니라 까지도 가 없다면 cham0287님께서 번역해주신 대로 두는 게 맞는 것 같습니다 😊
|
수고하셨습니다:) 리뷰 확인해주세요 😊 |
…-routes.mdx Co-authored-by: JiHee Han <[email protected]>
…-routes.mdx Co-authored-by: JiHee Han <[email protected]>
…-routes.mdx Co-authored-by: JiHee Han <[email protected]>
…-routes.mdx Co-authored-by: JiHee Han <[email protected]>
…-routes.mdx Co-authored-by: JiHee Han <[email protected]>
g2hhh2ee
approved these changes
Jul 17, 2023
|
|
||
| For example, `app/shop/[[...slug]]/page.js` will **also** match `/shop`, in addition to `/shop/clothes`, `/shop/clothes/tops`, `/shop/clothes/tops/t-shirts`. | ||
| 예를 들어, `app/shop/[[...slug]]/page.js` 는 `/shop/clothes`, `/shop/clothes/tops`, `/shop/clothes/tops/t-shirts` **이외에도** `/shop` 과 일치합니다. |
There was a problem hiding this comment.
그렇네요! 저도 바로 밑의 문장까지 이어짐을 고려해 /shop을 강조하는 게 맞다고 생각하여 앞쪽으로 배치한 것이었으나 뿐만아니라 까지도 가 없다면 cham0287님께서 번역해주신 대로 두는 게 맞는 것 같습니다 😊
|
LGTM! 기여해주셔서 감사합니다 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
기여자용
문서 개선
pnpm prettier-fix를 실행하여 서식 문제를 해결합니다. - 문서 기여 가이드를 읽고 문서 지침을 따르는지 확인하세요: https://github.com/Nextjs-kr/Nextjs.ko/blob/main/packages/next/README.mdProgress
pnpm prettier-fix