Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

02-app > 01-building-your-application > 06-configuring > 05-mdx.mdx #322

Merged
merged 4 commits into from
Jul 10, 2023
Merged

02-app > 01-building-your-application > 06-configuring > 05-mdx.mdx #322

merged 4 commits into from
Jul 10, 2023

Conversation

presuit
Copy link
Contributor

@presuit presuit commented Jun 28, 2023 •
edited
Loading

기여자용

문서 개선

Progress

issue: #127

@presuit presuit requested a review from ChanghyeonYoon as a code owner June 28, 2023 01:31
@ChanghyeonYoon ChanghyeonYoon added the documentation 문서 작업 label Jun 28, 2023
@devyuriii devyuriii linked an issue Jun 30, 2023 that may be closed by this pull request
05-mdx.mdx #127
Closed
@devyuriii devyuriii mentioned this pull request Jun 30, 2023
Open
@devyuriii devyuriii requested review from devyuriii and removed request for ChanghyeonYoon July 6, 2023 06:53
devyuriii
devyuriii reviewed Jul 6, 2023
View reviewed changes
Copy link
Contributor

@devyuriii devyuriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! h2(##) 제목에 모두 링크를 달아주셨는데, 임의로 링크를 달기 보단 원문을 유지해주세요!
h2 제목 수가 많은데 모두 동일한 리뷰를 달면 길어질 것 같아 하나의 코멘트로 전달드립니다 :)
리뷰 반영 부탁드립니다!

@presuit presuit requested a review from devyuriii July 8, 2023 11:27
devyuriii
devyuriii approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@devyuriii devyuriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥰
수고하셨습니다! 추가로 작업 원하시면 이슈에 댓글 부탁드립니다 👍

@devyuriii devyuriii merged commit 975a7a6 into Nextjs-kr:main Jul 10, 2023
@sungh0lim sungh0lim mentioned this pull request Jul 31, 2023
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HA-SEUNG-JEONG HA-SEUNG-JEONG HA-SEUNG-JEONG left review comments

@devyuriii devyuriii devyuriii approved these changes

Assignees

@presuit presuit

Labels
documentation 문서 작업 In Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

05-mdx.mdx
4 participants
@presuit @devyuriii @HA-SEUNG-JEONG @ChanghyeonYoon