Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

02-app > 02-api-reference > 04-functions > use-selected-layout-segment.mdx 번역 #269

Merged
merged 2 commits into from
Jul 11, 2023
Merged

02-app > 02-api-reference > 04-functions > use-selected-layout-segment.mdx 번역 #269

merged 2 commits into from
Jul 11, 2023

Conversation

SeongsangCHO
Copy link
Contributor

기여자용

문서 개선

Progress

@SeongsangCHO
번역초안
5f6f089 
0626 번역, prettier-fix수행

best practices참고

번역하면안되는 훅 -> hook으로 변경

맞춤법 검사기 - 임포트 -> 가져오기

소제목수정
@ChanghyeonYoon ChanghyeonYoon added the documentation 문서 작업 label Jun 27, 2023
@SeongsangCHO SeongsangCHO mentioned this pull request Jun 28, 2023
Closed
@ChanghyeonYoon
Copy link
Member

ref #101

@ChanghyeonYoon ChanghyeonYoon mentioned this pull request Jun 29, 2023
Open
ChanghyeonYoon
ChanghyeonYoon reviewed Jun 29, 2023
View reviewed changes
Copy link
Member

@ChanghyeonYoon ChanghyeonYoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! 리뷰 반영 부탁드립니다!

docs/02-app/02-api-reference/04-functions/use-selected-layout-segment.mdx Outdated
@@ -31,24 +31,25 @@ export default function ExampleClientComponent() {
}
```

> **Good to know**:
> **알면 좋을 것**:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know 는 가이드에따라 참고로 통일해주세요!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f8f1f65 반영했습니다 !

@SeongsangCHO SeongsangCHO removed their assignment Jul 10, 2023
@yoo-jimin127 yoo-jimin127 self-requested a review July 11, 2023 09:23
yoo-jimin127
yoo-jimin127 approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@yoo-jimin127 yoo-jimin127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! 수고 많으셨습니다 :) 👍
추가로 할당하고 싶으신 티켓은 이슈에 작성해주세요!

@yoo-jimin127 yoo-jimin127 merged commit 0274543 into Nextjs-kr:main Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChanghyeonYoon ChanghyeonYoon ChanghyeonYoon left review comments

@yoo-jimin127 yoo-jimin127 yoo-jimin127 approved these changes

Assignees

@SeongsangCHO SeongsangCHO

Labels
documentation 문서 작업 In Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SeongsangCHO @ChanghyeonYoon @yoo-jimin127