Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐ŸŽ‰ 05-custom-document #148

Merged
merged 3 commits into from
Jun 22, 2023
Merged

๐ŸŽ‰ 05-custom-document #148

merged 3 commits into from
Jun 22, 2023

Conversation

daveg7lee
Copy link
Contributor

@daveg7lee daveg7lee commented Jun 21, 2023

๊ธฐ์—ฌ์ž์šฉ

๋ฌธ์„œ ๊ฐœ์„ 

  • PR์„ ์—ด๊ธฐ ์ „์— pnpm prettier-fix๋ฅผ ์‹คํ–‰ํ•˜์—ฌ ์„œ์‹ ๋ฌธ์ œ๋ฅผ ํ•ด๊ฒฐํ•ฉ๋‹ˆ๋‹ค. - ๋ฌธ์„œ ๊ธฐ์—ฌ ๊ฐ€์ด๋“œ๋ฅผ ์ฝ๊ณ  ๋ฌธ์„œ ์ง€์นจ์„ ๋”ฐ๋ฅด๋Š”์ง€ ํ™•์ธํ•˜์„ธ์š”: https://github.com/Nextjs-kr/Nextjs.ko/blob/main/packages/next/README.md

Progress

Copy link
Member

@ChanghyeonYoon ChanghyeonYoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹ค! ๋ฆฌ๋ทฐ ๋ฐ˜์˜ ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค!

@ChanghyeonYoon ChanghyeonYoon added the documentation ๋ฌธ์„œ ์ž‘์—… label Jun 21, 2023
@ChanghyeonYoon ChanghyeonYoon linked an issue Jun 21, 2023 that may be closed by this pull request

For [React 18](/docs/getting-started/react-essentials) support, we recommend avoiding customizing `getInitialProps` and `renderPage`, if possible.
[React 18](/docs/getting-started/react-essentials) ์ง€์›์„ ์œ„ํ•ด, ๊ฐ€๋Šฅํ•˜๋‹ค๋ฉด `getInitialProps`์™€ `renderPage`์„ ์ปค์Šคํ„ฐ๋งˆ์ด์ง• ํ•˜์ง€ ์•Š๋Š”๊ฒƒ์„ ์ถ”์ฒœํ•ฉ๋‹ˆ๋‹ค.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[React 18](/docs/getting-started/react-essentials) ์ง€์›์„ ์œ„ํ•ด, ๊ฐ€๋Šฅํ•˜๋‹ค๋ฉด `getInitialProps`์™€ `renderPage`์„ ์ปค์Šคํ„ฐ๋งˆ์ด์ง• ํ•˜์ง€ ์•Š๋Š”๊ฒƒ์„ ์ถ”์ฒœํ•ฉ๋‹ˆ๋‹ค.
[React 18](/docs/getting-started/react-essentials) ์ง€์›์„ ์œ„ํ•ด, ๊ฐ€๋Šฅํ•˜๋‹ค๋ฉด `getInitialProps`์™€ `renderPage`์„ ์ปค์Šคํ„ฐ๋งˆ์ด์ง• ํ•˜์ง€ ์•Š๋Š” ๊ฒƒ์„ ์ถ”์ฒœํ•ฉ๋‹ˆ๋‹ค.

@daveg7lee
Copy link
Contributor Author

๋ฆฌ๋ทฐ ๋ฐ˜์˜ํ•˜์˜€์Šต๋‹ˆ๋‹ค!

Copy link
Member

@ChanghyeonYoon ChanghyeonYoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹ค! ์ถ”๊ฐ€๋กœ ํ•˜์‹œ๊ณ  ์‹ถ์€ ํ‹ฐ์ผ“์ด ์žˆ๋‹ค๋ฉด ์‹ ์ฒญํ•ด์ฃผ์…”๋„ ๋ฉ๋‹ˆ๋‹ค!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation ๋ฌธ์„œ ์ž‘์—…
Projects
None yet
Development

Successfully merging this pull request may close these issues.

05-custom-document.mdx
4 participants