-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
목표 수정 디자인 v2 반영 #75
Merged
Merged
목표 수정 디자인 v2 반영 #75
+738
−330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
988184b
to
fd9643d
Compare
nohjunh
reviewed
Feb 21, 2025
feature/goal/src/main/kotlin/com/chipichipi/dobedobe/feature/goal/DetailGoalScreen.kt
Outdated
Show resolved
Hide resolved
feature/goal/src/main/kotlin/com/chipichipi/dobedobe/feature/goal/DetailGoalScreen.kt
Outdated
Show resolved
Hide resolved
feature/goal/src/main/kotlin/com/chipichipi/dobedobe/feature/goal/DetailGoalScreen.kt
Outdated
Show resolved
Hide resolved
feature/goal/src/main/kotlin/com/chipichipi/dobedobe/feature/goal/EditGoalScreen.kt
Outdated
Show resolved
Hide resolved
feature/goal/src/main/kotlin/com/chipichipi/dobedobe/feature/goal/DetailGoalViewModel.kt
Outdated
Show resolved
Hide resolved
feature/goal/src/main/kotlin/com/chipichipi/dobedobe/feature/goal/component/GoalEditor.kt
Show resolved
Hide resolved
feature/goal/src/main/kotlin/com/chipichipi/dobedobe/feature/goal/EditGoalViewModel.kt
Outdated
Show resolved
Hide resolved
feature/goal/src/main/kotlin/com/chipichipi/dobedobe/feature/goal/component/GoalEditor.kt
Outdated
Show resolved
Hide resolved
nohjunh
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오늘 바쁘셨을텐데 고생하셨습니다~!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
디자인 v2 반영했습니다~ PR 을 조금 더 쪼개볼걸 그랬네요 ㅎㅎ..
DobeDobeTextField MaxLine 추가
DobeDobeCenterAlignedTopAppBar 추가
ic_flag asset 문제 있어 수정
AddGoal, EditGoal 모두 화면 진입 시, 소프트 키보드 띄우도록 함
기존에 UI 단에 있던 TextFieldState 를 VIewModel 로 이동
GoalTopAppBar 구현 시, Material3 의 TopAppBar 가 기본적으로 HorizontalPadding 을 4.dp 가지고 있음. 이를 고려하여 padding 을 주었다는 것을 명시하기 위해
12.dp - TopAppBarHorizontalPadding
로 계산Screen_Recording_20250220_013936_dobedobe.mp4