Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

목표 수정 디자인 v2 반영 #75

Merged
merged 24 commits into from
Feb 21, 2025
Merged

Conversation

murjune
Copy link
Member

@murjune murjune commented Feb 19, 2025

디자인 v2 반영했습니다~ PR 을 조금 더 쪼개볼걸 그랬네요 ㅎㅎ..

  • DobeDobeTextField MaxLine 추가

  • DobeDobeCenterAlignedTopAppBar 추가

  • ic_flag asset 문제 있어 수정

  • AddGoal, EditGoal 모두 화면 진입 시, 소프트 키보드 띄우도록 함

  • 기존에 UI 단에 있던 TextFieldState 를 VIewModel 로 이동

  • GoalTopAppBar 구현 시, Material3 의 TopAppBar 가 기본적으로 HorizontalPadding 을 4.dp 가지고 있음. 이를 고려하여 padding 을 주었다는 것을 명시하기 위해 12.dp - TopAppBarHorizontalPadding 로 계산

Screen_Recording_20250220_013936_dobedobe.mp4

@murjune murjune self-assigned this Feb 19, 2025
@murjune murjune force-pushed the feat/goal-detail-design-v2 branch from 988184b to fd9643d Compare February 19, 2025 16:40
@murjune murjune marked this pull request as ready for review February 19, 2025 16:40
Copy link
Member

@nohjunh nohjunh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오늘 바쁘셨을텐데 고생하셨습니다~!!

@murjune murjune merged commit 1c86b14 into develop Feb 21, 2025
1 check passed
@murjune murjune deleted the feat/goal-detail-design-v2 branch February 21, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants