feat: 데스크탑 레이아웃 적용 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haryung-lee
approved these changes
Nov 12, 2024
src/renderer/shared/ui/layouts.tsx
Outdated
Comment on lines
8
to
21
| export type MobileLayoutProps = { | ||
| children: React.ReactNode; | ||
| }; | ||
|
|
||
| export const MobileLayout = ({ children }: MobileLayoutProps) => { | ||
| return <div className="m-auto h-dvh max-w-md bg-background-primary">{children}</div>; | ||
| }; | ||
|
|
||
| export type DesktopLayoutProps = { | ||
| title?: string; | ||
| children: React.ReactNode; | ||
| }; | ||
|
|
||
| export const DesktopLayout = ({ title, children }: DesktopLayoutProps) => { |
There was a problem hiding this comment.
MobileLayout, DesktopLayout 에서 큰 차이가 사이드바 여부인것 같은데,
SidebarLayout, SimpleLayout(or NoSidebarLayout?) 으로 네이밍하는건 어때?!
There was a problem hiding this comment.
오 좋은 의견!!
기존 화면이 모바일향이고, 이번에 사이드바가 추가된 데스크탑향이여서 이런식으로 네이밍을 했는데
이 컨텍스트를 지운다면 사실 Sidebar or not 과 같은 형식의 네이밍이 좋은 것 같네!
그럼 SidebarLayout, SimpleLayout 이 형태로 반영할게~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
체크리스트