-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: github action을 활용한 release 준비 #46
Merged
Merged
Changes from 26 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
53624ec
윈도우 최소 창 사이즈
young-do 9f45d51
시간 끝났을때 창 focus 될수있도록 준비
young-do 5f6e5c5
트레이 적용
young-do 344b310
알림 타이틀은 서비스 이름이 나오도록
young-do 8964cf5
Merge remote-tracking branch 'origin/main' into feature/setup
young-do e48ed04
버전 및 앱 이름 수정
young-do 0588ce0
icon들 적용
young-do e8c211c
앱 빌드시 한국어 패키지명으로 보이도록
young-do bc44c37
창에 앱 이름 안보이게
young-do ea8270d
Revert "앱 빌드시 한국어 패키지명으로 보이도록"
young-do 13442b9
tray 아이콘은 dataurl 로 전달..
young-do 1d6fb2a
빌드 후에도 devtool 열려서 비활성화
young-do 20d6a40
창이 닫혔을때는 다시 창 만들도록
young-do 19763d6
권한 묻는 팝업을 알림을 생성해서 뜨도록
young-do 9a5a08d
고양이가 없을때만 다음 페이지가 선택페이지가 되도록
young-do 2741241
Merge remote-tracking branch 'origin/main' into feature/setup
young-do 803c0c5
일단 signing만 적용
young-do 169e745
release를 위한 준비
young-do a6b427d
license 다시 복구
young-do 24da8da
자동 업데이트 추가
young-do d76593c
tag 푸시될때 draft로 배포되도록
young-do 6a29929
auto update dependencies로 이동
young-do bacb40c
host 값이 기본값으로 전달되지 않아 명시
young-do f71e2ad
서버 url 환경변수가 빌드시에 반영되도록
young-do cbe5ae2
0.0.1-alpha.4
young-do 9114cbf
0.0.1-alpha.5
young-do cea68e4
Merge remote-tracking branch 'origin/main' into feature/ready-to-release
young-do File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
name: Release | ||
# @see: https://dev.to/erikhofer/build-and-publish-a-multi-platform-electron-app-on-github-3lnd | ||
on: | ||
push: | ||
tags: | ||
- 'v*' | ||
|
||
jobs: | ||
publish_on_linux: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-node@v4 | ||
with: | ||
node-version: 18 | ||
cache: 'yarn' | ||
- name: install dependencies | ||
run: yarn install | ||
- name: publish | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
VITE_API_SERVER_URL: ${{ secrets.VITE_API_SERVER_URL }} | ||
run: yarn run publish | ||
|
||
publish_on_mac: | ||
runs-on: macos-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-node@v4 | ||
with: | ||
node-version: 18 | ||
- name: install dependencies | ||
run: yarn install | ||
# see: https://dev.to/rwwagner90/signing-electron-apps-with-github-actions-4cof | ||
- name: Add MacOS certs | ||
run: chmod +x add-osx-cert.sh && ./add-osx-cert.sh | ||
env: | ||
CERTIFICATE_OSX_APPLICATION: ${{ secrets.CERTIFICATE_OSX_APPLICATION }} | ||
CERTIFICATE_PASSWORD: ${{ secrets.CERTIFICATE_PASSWORD }} | ||
- name: Add api key file | ||
run: | | ||
echo "${{ secrets.APPLE_API_KEY_CONTENT }}" > authKey.p8 | ||
APPLE_API_KEY=$(realpath authKey.p8) | ||
echo "APPLE_API_KEY=$APPLE_API_KEY" >> $GITHUB_ENV | ||
- name: publish | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
VITE_API_SERVER_URL: ${{ secrets.VITE_API_SERVER_URL }} | ||
APPLE_API_KEY: ${{ env.APPLE_API_KEY }} | ||
APPLE_API_KEY_ID: ${{ secrets.APPLE_API_KEY_ID }} | ||
APPLE_API_ISSUER: ${{ secrets.APPLE_API_ISSUER }} | ||
run: DEBUG=* yarn run publish | ||
|
||
publish_on_win: | ||
runs-on: windows-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-node@v4 | ||
with: | ||
node-version: 18 | ||
- name: install dependencies | ||
run: yarn install | ||
- name: publish | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
VITE_API_SERVER_URL: ${{ secrets.VITE_API_SERVER_URL }} | ||
run: yarn run publish |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
#!/usr/bin/env sh | ||
|
||
# see: https://dev.to/rwwagner90/signing-electron-apps-with-github-actions-4cof | ||
KEY_CHAIN=build.keychain | ||
CERTIFICATE_P12=certificate.p12 | ||
|
||
# Recreate the certificate from the secure environment variable | ||
echo $CERTIFICATE_OSX_APPLICATION | base64 --decode > $CERTIFICATE_P12 | ||
|
||
#create a keychain | ||
security create-keychain -p actions $KEY_CHAIN | ||
|
||
# Make the keychain the default so identities are found | ||
security default-keychain -s $KEY_CHAIN | ||
|
||
# Unlock the keychain | ||
security unlock-keychain -p actions $KEY_CHAIN | ||
|
||
security import $CERTIFICATE_P12 -k $KEY_CHAIN -P $CERTIFICATE_PASSWORD -T /usr/bin/codesign; | ||
|
||
security set-key-partition-list -S apple-tool:,apple: -s -k actions $KEY_CHAIN | ||
|
||
# remove certs | ||
rm -fr *.p12 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
{ | ||
"name": "my-app", | ||
"productName": "my-app", | ||
"version": "1.0.0", | ||
"description": "My Electron application description", | ||
"name": "mohanyang", | ||
"productName": "mohanyang", | ||
"version": "0.0.1-alpha.5", | ||
"description": "Pomodoro timer desktop app with cat", | ||
"main": ".vite/build/main.js", | ||
"scripts": { | ||
"start": "electron-forge start", | ||
|
@@ -20,13 +20,15 @@ | |
"@electron-forge/plugin-auto-unpack-natives": "^7.4.0", | ||
"@electron-forge/plugin-fuses": "^7.4.0", | ||
"@electron-forge/plugin-vite": "^7.4.0", | ||
"@electron-forge/publisher-github": "^7.4.0", | ||
"@electron/fuses": "^1.8.0", | ||
"@types/node": "^20.14.10", | ||
"@types/react": "^18.3.3", | ||
"@types/react-dom": "^18.3.0", | ||
"@typescript-eslint/eslint-plugin": "^7.16.0", | ||
"@typescript-eslint/parser": "^7.16.1", | ||
"autoprefixer": "^10.4.19", | ||
"dotenv": "^16.4.5", | ||
"electron": "31.2.0", | ||
"eslint": "^8.0.1", | ||
"eslint-config-prettier": "^9.1.0", | ||
|
@@ -41,11 +43,20 @@ | |
"vite": "^5.0.12", | ||
"vite-plugin-svgr": "^4.2.0" | ||
}, | ||
"keywords": [], | ||
"author": { | ||
"name": "leeharyung", | ||
"email": "[email protected]" | ||
}, | ||
"contributors": [ | ||
{ | ||
"name": "leeharyung", | ||
"email": "[email protected]" | ||
}, | ||
{ | ||
"name": "young-do cho", | ||
"email": "[email protected]" | ||
} | ||
], | ||
"license": "MIT", | ||
"dependencies": { | ||
"@lottiefiles/dotlottie-react": "^0.8.8", | ||
|
@@ -72,6 +83,7 @@ | |
"react-router-dom": "^6.25.0", | ||
"tailwind-merge": "^2.4.0", | ||
"tailwindcss-animate": "^1.0.7", | ||
"update-electron-app": "^3.0.0", | ||
"usehooks-ts": "^3.1.0", | ||
"vaul": "^0.9.1" | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,6 @@ | ||
// @see: https://www.electronjs.org/docs/latest/tutorial/context-isolation#usage-with-typescript | ||
export interface IElectronAPI { | ||
showWindow: () => void; | ||
changeTrayIcon: (icon: string) => void; | ||
getMachineId: () => Promise<string>; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요거 저도 알아야 할려나영 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
실제 키값??? 일단 값은 github action에 저장되어있긴 함!
자세한지는 모르겠지만 아래 참고용!
https://www.electronforge.io/guides/code-signing/code-signing-macos#option-2-using-an-app-store-connect-api-key