-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the slack platform support #71
Conversation
Thanks, Ash. The community will check this by the following Monday. |
Could you please build now? |
😪 |
Please take a closer look and say something |
I'll take a close look after CI is passed.
If you have no clue what I'm saying, learn how to programming using |
Sorry,I forget gofmt, please stay online,I change now |
Clear |
Don't run,I will all checked then text you,when totally resolved |
Man it has been a long time, Please finish |
Good, but we still need a test to represent the whole workflow (at least validation workflow). Especially, I want to know the format of field Also, don't put Slack API key in the test code, just code and run locally on your machine. Commit the core part when you're done.
|
Build |
sorry, i'm working. |
Please finish quickly |
So you still don't understand the whole workflow of how ProofService works. Learn it in doc, and try to use it (MaskBook browser plugin's identity binding function) first. Until then, let's discuss about impl details. |
Also, don't post private chat into this public discussion. |
|
No,This is example. |
What I need is a real It will be better if you add some instruction of "how to get ProofLocation" in |
My public channel id,C04Q3P6H7TK |
Write it in test then. |
And you say do we need to add slack,Slack is better than discord,Big company uses slack,Most slack users are company employees. |
I thought a little bit after that, I'm now realized that it worth to be supported, for on-premise scenario. |
Should we add page limit to our code? |
I got ProofLocation shape, ProofLocation will be proof message link. |
Okay, Please help me in testing code |
Please tell🙏🙏 |
Please would you cooperate to end it? |
Don't flood message in PR. Github is not IM, you should NOT expect immediate response from others.
Write a small
Impossible you can't generate sigs. There are many helper functions in
|
I'M NOT A TEACHER CORRECTING YOUR HOMEWORK. REPRESENT YOUR RESULTS IN YOUR CODE. I'll not respond to any homework-ish reply from now then. |
🥲 |
Please take a look now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current code is OK to merge after CI turns green. Thank you for your contribution!
I hope this time will work,,,RUN