Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: message statistic page header cell layout #40

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Conversation

zjns
Copy link
Contributor

@zjns zjns commented Jul 7, 2024

修复消息统计数据页面标题布局

photo_2024-07-07_19-05-31

官方版本没这个问题,应该是这个提交导致的 dd08362

Summary by Sourcery

This pull request addresses a layout issue on the message statistics page by adjusting the padding of header cells to ensure proper alignment.

  • Bug Fixes:
    • Fixed the layout of the header cells on the message statistics page by adjusting padding values.

Copy link

sourcery-ai bot commented Jul 7, 2024

Reviewer's Guide by Sourcery

This pull request addresses layout issues in the message statistics page by adjusting the padding of header cells. Additionally, it refactors a hardcoded option value in ChatActivity to use a predefined constant for better code maintainability.

File-Level Changes

Files Changes
TMessagesProj/src/main/java/org/telegram/ui/MessageStatisticActivity.java Adjusted the layout of header cells by modifying padding values to ensure consistent spacing.
TMessagesProj/src/main/java/org/telegram/ui/ChatActivity.java Refactored option value assignment to use a constant instead of a hardcoded value.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @zjns - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 3 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@omg-xtao omg-xtao merged commit 30b41f7 into NextAlone:dev Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants