Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

PHP 8 Support #51

Merged
merged 1 commit into from
Nov 13, 2020
Merged

PHP 8 Support #51

merged 1 commit into from
Nov 13, 2020

Conversation

driesvints
Copy link
Contributor

@driesvints driesvints commented Nov 3, 2020 •
edited
Loading

I didn't add PHP 8 builds as it seems this one is untested on PHP 7.3 and 7.4 as well.

@driesvints driesvints mentioned this pull request Nov 3, 2020
Merged
@driesvints
Copy link
Contributor Author

We'll need this for laravel/vonage-notification-channel#39

@driesvints
Copy link
Contributor Author

@dragonmantank any chance we can merge and get this on tagged soon? Since PHP 8 GA is approaching rapidly atm. Thanks! :)

@dragonmantank
Copy link
Contributor

Yup, I will get this handled by later today!

@dragonmantank
Copy link
Contributor

Dealing with internet issues and cleaning up some stuff from our rebrand still. Should have this good to go this weekend if I still don't get it completed tonight.

@driesvints
Copy link
Contributor Author

No worries at all! We still have some time for PHP 8 GA 👍

@dragonmantank dragonmantank mentioned this pull request Nov 9, 2020
Merged
@dragonmantank dragonmantank merged commit 0b73506 into Nexmo:master Nov 13, 2020
@driesvints driesvints deleted the php8 branch November 16, 2020 09:04
@driesvints
Copy link
Contributor Author

Thanks @dragonmantank! Any idea when a new release will be tagged?

@dragonmantank
Copy link
Contributor

As soon as some underlying dependencies get PHP 8 support. Right now the package cannot be installed due to some upstream packages (specifically laminas/laminas-diactoros - laminas/laminas-diactoros#46)

@driesvints
Copy link
Contributor Author

Looks like that got merged and tagged! 🥳

https://github.com/laminas/laminas-diactoros/releases/tag/2.5.0

@driesvints driesvints mentioned this pull request Nov 23, 2020
Merged
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@driesvints @dragonmantank