Repository navigation
Make child chore denial test reach manager authorization on main - #899
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This was referenced Oct 3, 2026
NewWorldVenture
marked this pull request as ready for review
October 4, 2026 03:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The child chore creation test could pass because its sibling fixture was missing, even if manager authorization was removed. Seed a valid sibling and require the manager-refusal message plus unchanged chore and assignment rows, so that regression is detected.
This transposes #891's six-line test-only fix onto current production main. Root's 10-case suite and targeted lint pass. An independent reviewer passed the suite on both the original candidate and current main; temporarily removing only
createChoreAction's manager check made the child denial fail on both trees. The older #891 base's failed Web/Mobile gates are historical evidence; this candidate requires fresh hosted checks. No product code, configuration or migrations change.