Repository navigation
Refuse malformed Calendar batch-delete receipts - #862
Closed
NewWorldVenture wants to merge 1 commit into
Closed
NewWorldVenture wants to merge 1 commit into
NewWorldVenture wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calendar batch deletion now refuses a non-nullish, non-array success receipt before reading the returned collection. The three-line guard preserves the existing SDK error path, arrays, nullish/204 empty receipts, filtered IDs, family scope and activity behavior. This draft is stacked on #860; only deleteEvents changes.
Validation: the same 22-case actual SDK synthetic suite passes on the candidate and ordinary root configuration with private source/observer variables absent. The exact parent has ten malformed-collection failures and twelve passing controls. All original assertions and all44 paired request/payload/activity vectors are retained. Full8GB nonincremental types and scoped two-file lint pass.
Refusal occurs after a synthetic DELETE reply. These tests do not establish prevented physical deletion, rollback, an actual database invariant or a full Undo workflow. Auth/context/provider/backend/PG/RLS execution is absent, and the fixture does not assert response headers. The selected published #860 parent differs from the original source62 module only by the unrelated UPDATE guard; the deletion routine is identical and sibling seams are unused.