Skip to content

Validate assignees before atomic Calendar batch creation #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NewWorldVenture wants to merge 1 commit into from
Closed

Validate assignees before atomic Calendar batch creation #860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions lib/services/calendar/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,27 @@ export async function createEvents(
if (seen.data.length > 0) return ok(seen.data);
}

const assigneeIds = rows
.map((row) => row.assignee_id)
.filter((id): id is string => id != null)
.filter((id, index, ids) => ids.findIndex((other) => sameId(other, id)) === index);
if (assigneeIds.length) {
const { data: members, error: memberError } = await scope.db
.from('family_members')
.select('id, family_id')
.eq('family_id', scope.familyId)
.in('id', assigneeIds);
if (memberError) {
return fail(describeDbError(memberError, 'Could not check those assignees.'), { code: SERVICE_CODES.db });
}
if (!Array.isArray(members) || !members.every((member) => member && typeof member === 'object'
&& !Array.isArray(member) && typeof member.id === 'string' && typeof member.family_id === 'string'
&& sameId(member.family_id, scope.familyId) && assigneeIds.some((id) => sameId(member.id, id)))
|| !assigneeIds.every((id) => members.some((member) => sameId(member.id, id)))) {
return fail('Choose assignees from your family.', { code: SERVICE_CODES.invalidInput });
}
}

const { data, error } = await scope.db.from('calendar_events').insert(rows).select('*');
if (error || !data) {
// On a keyed batch this is what losing the race looks like: the winner's
Expand Down
Loading
Loading