Repository navigation
Refuse failed connected and financial account lookups - #761
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
NewWorldVenture
left a comment
NewWorldVenture
left a comment
There was a problem hiding this comment.
Independent source and executable review clears the narrow lookup-error refusal at this exact head. Both guards run before cached-row reuse or getStripe; payloads, family predicates, idempotency and provider/mirror failure behavior are unchanged. The frozen 44-case suite passed independently, with zero external attempts; the same tests reproduce 18 baseline failures and detect guards moved past reuse or provider initialization.
A separate sealed harness through current-main real server actions and actual candidate helpers passes 48/48. Identical old helpers yield 20 failures and 28 controls passing: returned lookup errors previously produced false successes, including deferred and data-plus-error cases. Healthy reuse/absence, provider rejection, rejected lookup, role/capability and deferred healthy controls pass on both. No real account, Treasury, database or provider operation occurred.
This clears scoped source review, not live persistence/recovery/concurrency or a whole Money workflow. Exact hosted CI and final combined-source checks remain required. Main f721 is held stable for its current post-merge run; preserve this author head.
1 participant
A returned error from the existing-account lookup previously allowed Connect/Treasury to reuse data returned with an error or continue to provider creation when data was absent. Both ensure helpers now reject that lookup before either path.
Only the initial lookup error guards and their paired regression suite change. Provider payloads, family scoping, idempotency keys, input defaults, healthy reuse/absence, and downstream error propagation are preserved.
Validation on Node 24.21.0: unchanged paired suite 18 failures / 26 controls before, 44/44 after; 268 related tests across 7 files pass; full TypeScript and scoped ESLint pass. Moving either guard below reuse causes 5 failures; below provider-factory access causes 9 failures. Sealed fakes and network barriers report zero real service/client/transport attempts.
Existing audit scope: LIBRARY-00A48F96544F and LIBRARY-A6243E0F741C. Synthetic helper acceptance only; no live provider, Treasury, persistence, or whole-workflow claim.