Skip to content

Page audit follow-up: C1-S9-127…134 — more pages in the reader's language - #612

Merged
NewWorldVenture merged 12 commits into
mainfrom
claude/bubaly-repo-connect-45d8k6
Sep 27, 2026
Merged

NewWorldVenture merged 12 commits into
mainfrom
claude/bubaly-repo-connect-45d8k6

Conversation

@NewWorldVenture

@NewWorldVenture NewWorldVenture commented Sep 27, 2026 •

Copy link
Copy Markdown
Owner

This follows #598, which merged as 177ed1a5. Main is merged in through 1180c77d (#586, #614, #615). Every change has an entry in finalaudit.md.

What changes

  • C1-S9-127: labels in settings, money timeline, calm, calendar and voting.
  • C1-S9-128: "Find a time" durations and windows, declutter zone health, zone kinds and clutter scores, and dining stats.
  • C1-S9-129: the move-date recalculation dialog's reasons and failure messages.
  • C1-S9-130: declutter.
    • Picking a template used to save its English title into the family's mission. Templates are now worded when they are shown and again when they are written.
    • The home summary and the "Goal:" line are translated.
  • C1-S9-131: journal moods, meals tabs, paperwork filters, planning chips and toasts, profile and security stats, and the kitchen chef's suggested asks. The planning toast used to read "undefined prep plans ready".
  • C1-S9-132: the family dashboard. On merge, main's own port (Port the logged-in-pages audit branch onto main, one fix at a time (PORT-001) #586) already covered the greeting's time zone and the suggestions, so main's version is kept.
  • C1-S9-133: every trip tab's forms: labels, options, add buttons, dialog titles and the required-field toast. The emergency tab's rows are fixed too.
  • C1-S9-134: the Food & Nutrition hub's page chips, counts and features panel.

Merge with #586

Wherever #586 translated the same lines, main's side is kept, and this branch's duplicate keys are dropped.

Checks

  • tsc: 0 errors.
  • eslint: clean on the changed files.
  • 43 test files (641 tests), covering i18n, the catalogues, the register and the changed modules: all pass.
  • CI on the previous head f980abc0: all green.
  • Catalogues compared with main: additions only.

PRODUCTION READY stays NO. The pending migrations stay unapplied, and four production secrets are missing.

🤖 Generated with Claude Code

https://claude.ai/code/session_01776xJyhVe8xJQvTGeNfT9T

… in the reader's language

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01776xJyhVe8xJQvTGeNfT9T
…er's language

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01776xJyhVe8xJQvTGeNfT9T
…der's language; lib summary and templates recorded OPEN

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01776xJyhVe8xJQvTGeNfT9T
@vercel

vercel Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
bubaly Ignored Ignored Sep 27, 2026 8:46pm UTC

Request Review

…uage

A picked mission template wrote its English lib title into the family's
mission (quick-add chips, form suggestions, plan-my-week). Templates are now
worded by zone kind and index when shown and when written; the lib keeps its
English as canonical data. The home summary and a zone's Goal line are keys.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01776xJyhVe8xJQvTGeNfT9T
… kitchen labels in the reader's language

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01776xJyhVe8xJQvTGeNfT9T
…speaks the reader's language

The greeting used the host's UTC hour, so a California morning read 'Good
evening'. Greeting, suggestions (plural forms), stat links, AI tool cards
and the progress legend are catalogue keys. Scanner findings 25 -> 0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01776xJyhVe8xJQvTGeNfT9T
TripCrudSection rendered each tab's English FieldDef labels, options and
add buttons as-is, with 'Edit {section}' titles; the emergency tab's rows
said Traveler / Allergies: / Meds: in English. A label map
(components/vacations/trip-labels.ts) words all 83 labels; unmapped labels
fall back to their English, never a raw key.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01776xJyhVe8xJQvTGeNfT9T
@NewWorldVenture
NewWorldVenture marked this pull request as ready for review September 27, 2026 20:01
…-connect-45d8k6

Main's #586 port translated much of the same code. Main's side is kept on
every overlapping hunk:
- family-dashboard: main's phaseGreeting (family timezone) and One/Many
  suggestion keys; this branch's getPlurals/suggest.* keys are dropped.
- declutter: main's SCORE_LABEL_KEYS and worst-spot keys; this branch's
  scoreLabel() is removed. The home summary sentence is still English on
  main (lib text), so this branch's catalogue wording stays.
- planning: main's prepPlan keys; the English 'Could not generate plans'
  fallback keeps this branch's key.
- food: main's tab-title key.
Catalogues: main's order and values plus this branch's keys still used;
orphans from the overlaps removed. Against main: additions only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01776xJyhVe8xJQvTGeNfT9T
@NewWorldVenture NewWorldVenture changed the title Page audit follow-up: C1-S9-127…129 — eight more modules in the reader's language Page audit follow-up: C1-S9-127…134 — more pages in the reader's language Sep 27, 2026
main's CI at fda9dcf failed in Typecheck with "Ineffective mark-compacts
near heap limit" (exit 134) at the 4,096 MB cap, after the same step had
passed at that cap on the heads before it. The step runs alone after the
build on a 16 GB runner, so it gets 6,144 MB.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01776xJyhVe8xJQvTGeNfT9T

Copy link
Copy Markdown
Owner Author

E2E on e65a2ae failed in one spec: session-storage-reconcile.spec.ts › "confirmed cookie removal reconciles both tabs once with both/both" (chromium). Both attempts timed out at 5 s waiting for signed-out and read ready.

I don't think this failure comes from this PR:

  • The spec loads only lib/supabase/client.ts, lib/auth/*, lib/offline/cache.ts and components/auth/session-keeper.tsx, and this PR changes none of them.
  • The same spec passed in main's E2E on fda9dcf.
  • On this PR's head it passes locally 3 runs × 17/17.

The same CI run on main (fda9dcf) also exposed a real red that isn't this PR's. Its Typecheck step ran out of heap at the 4,096 MB cap ("Ineffective mark-compacts near heap limit", exit 134). This PR now carries that fix (5c48a0a: the CI typecheck step gets 6,144 MB). The new head's run is the re-run for both issues.


Generated by Claude Code

@NewWorldVenture
NewWorldVenture merged commit 559f40f into main Sep 27, 2026
7 checks passed
NewWorldVenture pushed a commit that referenced this pull request Sep 27, 2026
…n-upgrade-20260927

Audit docs keep this branch's CSP readiness checkpoint and its recount (13,830 NOT STARTED / 381 IN PROGRESS).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01776xJyhVe8xJQvTGeNfT9T
NewWorldVenture pushed a commit that referenced this pull request Sep 27, 2026
… branch; batch table keeps B12 done and B13

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DXw2nu25BjyRfA6Fg3YiMS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants