Repository navigation
Re-sign encoded family photo URLs as the current viewer - #599
Merged
NewWorldVenture merged 1 commit intoSep 27, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
NewWorldVenture
marked this pull request as ready for review
September 27, 2026 17:00
NewWorldVenture
pushed a commit
that referenced
this pull request
Sep 27, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KRUgA6hD6QgzmtpSP6TUmP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A stored signed photo URL with an encoded bucket name (
family%2Dmedia) was treated as an external image and rendered without checking the current viewer. The media parser now decodes route segments before recognizing the bucket, then validates and decodes the object path once. Both canonical and encoded references use the viewer's Storage signing request; denial renders no image. Other buckets and external image URLs retain their behavior.Validation: the new unit cases fail on the old parser (12 failures, 34 passing controls) and pass with the repair (46/46 focused cases). Actual React, Supabase SDK, cookies and FamilyMediaImg browser tests reproduce both encoded failures on the old parser and pass all 11 ownership/hydration cases with the fix. Scoped strict types and lint pass. The complete source gates pass: 20,735 unit tests across 1,623 files, the 247-page production build, generated-route strict types, and lint with 15 existing warnings. All 5,194 files and modes were verified before and after; only five audit documents differ between the tested tree and this commit. Hosted CI and this parser's production rollout remain pending.
The five audit documents record main576's verified production rollout, corrected worker CI success (1,764 E2E and 20,701 unit cases across three zones), and the remaining media/provider limitations. Only the three verified worker/support rows close; all permanent IDs and Claude page claims remain intact. The underlying public bucket finding remains open. Browser transport uses synthetic auth, Storage replies and image bytes; this does not claim a live Storage RLS bypass or production private-image verification.