Repository navigation
Public review page no longer shows seeder placeholder text; auditor flags placeholder text - #589
Merged
Merged
Conversation
On bubaly.com, /reviews/new greeted every visitor with "Important task #1" over "Sample reputation settings content generated for testing purposes. Row 1.". The page reads the reputation_settings singleton, and that row still holds the database seeder's text. The row has no slug, so isSyntheticSeedSlug cannot recognise it. isSeederText() matches the two shapes the seeder writes, and realTextOr() falls back to DEFAULT_REPUTATION field by field. The row itself still needs an admin edit in production; the page no longer depends on that. scripts/audit-live-pages.mjs now also flags text a visitor should never read: - seeder placeholders and lorem ipsum; - a value rendered as undefined, NaN or [object Object]; - an unfilled {{template}}; - a raw translation key. It flags /reviews/new, and gave no false positives across the first 33 public pages (home, pricing, features, legal, auth). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TRY21ZKsFrfB3qtoP972A4
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This was referenced Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the live page audit of www.bubaly.com, following #588.
Fixed
/reviews/newshowed seeder placeholder text to every visitor. The page displayed "Important task Remove free plan and default pricing to yearly billing #1" and "Sample reputation settings content generated for testing purposes. Row 1." It reads thereputation_settingssingleton row, and production still has the seeder's text there. A settings row has no slug, soisSyntheticSeedSlugcannot catch it.isSeederText()matches the two exact shapes the seeder writes.realTextOr()falls back toDEFAULT_REPUTATIONfield by field.Auditor
scripts/audit-live-pages.mjsnow also flags text a visitor should never read:undefined,NaNor[object Object];{{template}};It flags
/reviews/new. Across the first 33 public pages (home, pricing, features, legal, auth) it raised no false positives.Checks
tscclean; eslint clean on the changed files.🤖 Generated with Claude Code
https://claude.ai/code/session_01TRY21ZKsFrfB3qtoP972A4
Generated by Claude Code