Repository navigation
Preserve selected plans through onboarding and calendar consent - #480
Closed
NewWorldVenture wants to merge 2 commits into
Closed
NewWorldVenture wants to merge 2 commits into
NewWorldVenture wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Sep 10, 2026
This was referenced Sep 10, 2026
NewWorldVenture
marked this pull request as ready for review
September 10, 2026 10:44
This was referenced Sep 10, 2026
Owner
Author
|
Shipped — this landed on It stayed open only because its base is Closing as redundant, not rejected. Generated by Claude Code |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A selected family plan now survives onboarding and calendar consent until the user deliberately opens its billing review. Completed accounts with a valid choice reach the review destination; unfinished setup and owned pending calendar activation keep their existing wizard path. Successful Finish offers a translated “Review selected plan” action alongside Start exploring. A failed or stale Finish cannot open review or clear the current draft, and no paid operation starts from the continuation.
The four-value plan hint stays separate from onboarding business data, trial/subscription writes and idempotency keys. Google and Microsoft continuation state carries only that validated hint while retaining its existing encrypted owner/provider/CSRF bindings and expiry. Success, cancellation and recoverable failure return the choice only when the continuation and current owner remain valid. Existing entitlement, dormant-connection and import-only boundaries are preserved.
Wizard actions submit a separate expected-owner assertion that the server checks against fresh authenticated context before onboarding writes. Retired Finish/Connect/preview callbacks stay inactive after account, family or selection changes, including a change away and back to the original value. Request-localized page metadata is added in all seven languages without account/provider reads.
This PR is stacked on #467 (
codex/strategy-onboarding-sync-access-20260909). Integrate it with auth selection #479 and Billing review #481. The shared parser is identical to the auth branch; the Billing companion supplies the selected tier/interval display and explicit current-account/household confirmation. This slice does not complete or deploy the full pricing flow.Validation at onboarding head
5f25c3189745205e56c54feef075e9051f5bc1da:bcbe500bc61ebf8b69e634d0f42b506acec86403passes the full suite: 11,794 tests across 1,093 files with--maxWorkers=4.These are controlled component/service/browser checks, not live Google/Microsoft consent, production schema or physical-device acceptance. No SQL, shared navigation or dependency changes are included; required core, mobile, database, E2E and Vercel checks now pass at the published head in CI run 34466394815. Ready for review; production deployment remains separate.