Repository navigation
Connect Ask to private purchase advice and complete household evidence - #438
Merged
NewWorldVenture merged 0 commit intoSep 10, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
NewWorldVenture
marked this pull request as ready for review
September 9, 2026 21:22
NewWorldVenture
force-pushed
the
claude/roadmap-implementation-ld8bon
branch
3 times, most recently
from
September 10, 2026 16:31
11aa925 to
677e44c
Compare
NewWorldVenture
merged commit Sep 10, 2026
2339ff9
into
claude/roadmap-implementation-ld8bon
8 checks passed
NewWorldVenture
force-pushed
the
claude/roadmap-implementation-ld8bon
branch
from
September 10, 2026 20:53
56d8dd0 to
404d5d5
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ask now answers purchase questions through the same deterministic household advisor as the wishlist panel, including when no language-model provider is configured. It checks owned items, related equipment, saved preferences, wishlist duplicates and an explicitly priced category budget. Missing evidence stays unavailable; child finance restrictions, gift surprises and the memory switch remain enforced.
The tool follows household trust settings. Approval restores the original requester's current identity and permissions, and stores the detailed answer in an owner-protected conversation. Family-visible approval receipts carry only a neutral completion summary. The requester gets a private result link with waiting, declined and retry states. Complete paginated reads prevent older inventory, preferences or expenses from disappearing from the answer.
Validation: TypeScript, changed-file ESLint, translation gate and diff checks pass. Full local suite: 9,594 passed; five established Windows path failures in household-trail, i18n-server-boundary (two), supabase-query-audit and untrusted-fence-ratchet remain unchanged. Tests cover real Ask dispatch, trust decisions, identity restoration, private delivery, edited approvals, transport failures and evidence beyond former row limits. Whole-app translation scanning still has the existing backlog; this PR adds all new copy in seven catalogues.
No migrations or shared-sidebar changes. Integration note: #436 also extends approval execution; preserve both its school source-completion hook and this private purchase-result hook when integrating.