Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to convert metadata #6

Closed
wants to merge 2 commits into from

Conversation

schuellerf
Copy link
Contributor

The metadata of the image does not seem to be converted without explicitly setting the exif argument.

Should I change this so this can be turned off via command line argument?

@NeverMendel
Copy link
Owner

Thank you Florian! Exporting the metadata is a very valuable feature to add.

Yes, could you please add a command line argument to avoid exporting the metadata? Some users might not want to export it as it might contain sensitive information like the location where the picture was taken.

@schuellerf
Copy link
Contributor Author

there you go, please check 😄

@NeverMendel
Copy link
Owner

Thank you! I made a couple of changes but cannot submit the commit to schuellerf/heif-convert.

image

I'll create a fork and a new PL!

@NeverMendel NeverMendel mentioned this pull request Oct 17, 2023
@NeverMendel
Copy link
Owner

FYI, image.save(output_filepath, quality=args.quality, exif=None) was throwing an error.

The feature is now live in version 1.1.0!

@schuellerf
Copy link
Contributor Author

FYI, image.save(output_filepath, quality=args.quality, exif=None) was throwing an error.

The feature is now live in version 1.1.0!

Oh wow, sorry, I think it worked for me also with None, thanks for the fix and thanks for the super quick release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants