Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support bool as dtype #691

Merged
merged 9 commits into from
Nov 1, 2018
Merged

support bool as dtype #691

merged 9 commits into from
Nov 1, 2018

Conversation

ajtritt
Copy link
Member

@ajtritt ajtritt commented Oct 30, 2018

Motivation

Fix #658

Checklist

  • Have you checked our Contributing document?
  • Have you ensured the PR description clearly describes problem and the solution?
  • Is your contribution compliant with our coding style ? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using #XXX notation where XXX is the issue number ?

@ajtritt ajtritt added this to the NWB 2.0 Full milestone Oct 30, 2018
@codecov
Copy link

codecov bot commented Oct 30, 2018

Codecov Report

Merging #691 into dev will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #691      +/-   ##
==========================================
+ Coverage   74.37%   74.57%   +0.19%     
==========================================
  Files          58       58              
  Lines        6774     6776       +2     
  Branches     1397     1398       +1     
==========================================
+ Hits         5038     5053      +15     
+ Misses       1338     1332       -6     
+ Partials      398      391       -7
Impacted Files Coverage Δ
src/pynwb/form/backends/hdf5/h5tools.py 68.79% <ø> (+0.7%) ⬆️
src/pynwb/form/spec/spec.py 78.64% <ø> (ø) ⬆️
src/pynwb/form/build/map.py 74.97% <0%> (+0.21%) ⬆️
src/pynwb/ecephys.py 97.32% <0%> (+0.92%) ⬆️
src/pynwb/form/utils.py 87.35% <0%> (+1.47%) ⬆️
src/pynwb/form/container.py 82.25% <0%> (+1.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32fdac9...43cab02. Read the comment docs.

@bendichter
Copy link
Contributor

@ajtritt is this ready to go? Are there other things we need to change?

@ajtritt ajtritt requested a review from oruebel October 31, 2018 18:20
@ajtritt
Copy link
Member Author

ajtritt commented Oct 31, 2018

@bendichter yes... someone just needs to review it ;)

@bendichter bendichter changed the title [WIP] support bool as dtype support bool as dtype Oct 31, 2018
@bendichter bendichter self-requested a review October 31, 2018 18:50
oruebel
oruebel previously approved these changes Oct 31, 2018
@bendichter
Copy link
Contributor

I'd like to add a test for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants