-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enh/epochs dynamic table #682
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #682 +/- ##
==========================================
- Coverage 75.27% 74.71% -0.56%
==========================================
Files 58 58
Lines 6738 6775 +37
Branches 1378 1392 +14
==========================================
- Hits 5072 5062 -10
- Misses 1273 1320 +47
Partials 393 393
Continue to review full report at Codecov.
|
…taWithoutBorders/pynwb into enh/epochs_dynamic_table
oruebel
approved these changes
Oct 25, 2018
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Converting Epochs to a DynamicTable will make it easier for users to add metadata about epochs. More specifically, users will no longer need to make an extension to add epoch metadata.
How to test the behavior?
Checklist
flake8
from the source directory.#XXX
notation whereXXX
is the issue number ?